fix(setup): Gracefully handle internal-only Cloud #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code API enablement Modify `setup_workload_identity.sh` to prevent script failure when enabling the internal-only `cloudcode-pa.googleapis.com` API. The API enablement command now includes `|| true`, allowing the script to continue for public users without permissions for this service.
spencer426
requested review from
R2wenD2,
benw307,
leehagoodjames and
verbanicm
Contributor
|
🤖 Hi @spencer426, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
nikhilkapoor0919
approved these changes
Jan 28, 2026
![gemini-cli[bot]](https://avatars.githubusercontent.com/in/1473539?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
📋 Review Summary
This pull request modifies the setup_workload_identity.sh script to gracefully handle the enablement of an internal-only Google Cloud API. The change prevents the script from failing for public users, which is a good improvement for usability.
🔍 General Feedback
- The approach of using
|| trueis a standard and effective way to handle non-critical failures in shell scripts.
Co-authored-by: gemini-cli[bot] <218312386+gemini-cli[bot]@users.noreply.github.com> Signed-off-by: Spencer <spencer.tang12@gmail.com>
bdmorgan
approved these changes
Jan 28, 2026
spencer426
added a commit
that referenced
this pull request
Jan 29, 2026
## What's Changed ### Bug Fixes * fix(setup): Gracefully handle internal-only Cloud by @spencer426 in #447 ### Documentation * docs: update a broken link of gemini cli by @Marukome0743 in #441 ### Other Changes * ci(mcp): version up GitHub MCP Server by @bdmorgan in #437 **Full Changelog**: v0.1.19...v0.1.20
Merged
google-github-actions-bot
added a commit
that referenced
this pull request
Jan 29, 2026
## What's Changed * ci(mcp): version up GitHub MCP Server by @Marukome0743 in #437 * docs: update a broken link of gemini cli by @Marukome0743 in #441 * fix(setup): Gracefully handle internal-only Cloud by @spencer426 in #447 * Release: v0.1.20 by @spencer426 in #449 * Revert "Release: v0.1.20" by @spencer426 in #450 ## New Contributors * @spencer426 made their first contribution in #447 **Full Changelog**: v0.1.19...v0.1.20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code API enablement Modify
setup_workload_identity.shto prevent script failure when enabling the internal-onlycloudcode-pa.googleapis.comAPI. The API enablement command now includes|| true, allowing the script to continue for public users without permissions for this service.