Fix: Handled AgentCardBuilder field inconsistencies#2099
Open
SyedMohamedHyder wants to merge 6 commits intogoogle:mainfrom
Open
Fix: Handled AgentCardBuilder field inconsistencies#2099SyedMohamedHyder wants to merge 6 commits intogoogle:mainfrom
SyedMohamedHyder wants to merge 6 commits intogoogle:mainfrom
Conversation
Collaborator
|
@seanzhou1023 Please help review. |
ce86765 to
c0da47b
Compare
|
Hello @seanzhou1023! Sorry for bothering. Please have a look on this fix when you find some time! |
wukath
reviewed
Nov 18, 2025
| @@ -198,10 +198,11 @@ async def test_build_with_custom_parameters( | |||
| assert result.description == "An ADK Agent" # Default description | |||
| # The source code uses doc_url parameter but AgentCard expects documentation_url | |||
| # Since the source code doesn't map doc_url to documentation_url, it will be None | |||
Collaborator
There was a problem hiding this comment.
can you update this comment as well?
Collaborator
|
Hi @SyedMohamedHyder ,Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR makes a few small improvements to the experimental Agent Card Builder feature:
AgentCardandAgentSkillfields to use snake_case instead of camelCase, in line with the project's conventions.doc_urlfield, which is not defined in theAgentCardmodel todocumentation_url.Rationale
Although this feature is still experimental, these changes help improve consistency and clarity:
The models currently allow camelCase access only for backwards compatibility and issue a deprecation warning when used. These aliases are planned to be removed in version 0.3.0. Updating to snake_case ensures the code aligns with the intended usage and avoids deprecation warnings. Below is the corresponding code from a2a-sdk.
Since
doc_urlisn’t a valid field onAgentCard, replacing it withdocumentation_urlhelps prevent confusion and ensures only supported fields are used.I have also updated the unit tests to ensure they correctly reflect the current model structure and remain reliable over time.
These are relatively minor changes, but I hope they help keep the codebase clean and aligned with the project's direction. Feedback is always welcome.