-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: Add LLM resource cleanup lifecycle with aclose() method #3577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
junseon-yoo
wants to merge
9
commits into
google:main
Choose a base branch
from
junseon-yoo:fix/llm-client-cleanup-v1.18.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+174
−5
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f937230
feat: Add LLM resource cleanup lifecycle with aclose() method
junseon-yoo 9f2fa8e
refactor: Apply code review suggestions from Gemini Code Assist
junseon-yoo 86288b2
Merge branch 'main' into fix/llm-client-cleanup-v1.18.0
junseon-yoo 1ebefcb
fix: Apply pyink formatting to LLM cleanup code
junseon-yoo dd17add
Merge remote-tracking branch 'origin/main' into fix/llm-client-cleanu…
junseon-yoo 5d1e464
Merge remote-tracking branch 'origin/main' into fix/llm-client-cleanu…
junseon-yoo fb4cb55
chore: Remove unrelated test files from PR
junseon-yoo c33a0a1
Merge remote-tracking branch 'origin/main' into fix/llm-client-cleanu…
junseon-yoo 8a34578
Merge remote-tracking branch 'origin/main' into fix/llm-client-cleanu…
junseon-yoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.