fix: issue 3785. id_token missing

[guillaumeblaquiere]

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

• Closes: id_token missing in OIDC credential #3785

Problem:
id_token value is not gathered and made available in the OIDC flow

Solution:

• Add the id_token field in the oauth2auth class
• Add the id_token field population when available in the oauth credential util

Manual End-to-End (E2E) Tests:

Tested with OIDC and OAuth flow, works well

[gemini-code-assist]

Summary of Changes

Hello @guillaumeblaquiere, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical omission in the OpenID Connect (OIDC) authentication flow by ensuring that the id_token is properly captured and stored. It introduces a dedicated field within the authentication credential model and updates the token utility to populate this field, thereby making the id_token accessible for OIDC-based authentications. This change enhances the system's compliance with OIDC specifications and provides necessary user identity information.

Highlights

• Bug Fix: Resolves issue id_token missing in OIDC credential #3785 where the id_token was not being captured during the OIDC authentication flow.
• Model Update: Added an id_token field to the OAuth2Auth class in auth_credential.py to store the OpenID Connect ID token.
• Token Population: Modified the update_credential_with_tokens utility function in oauth2_credential_util.py to correctly populate the new id_token field when it is available in the token response.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly adds support for id_token in the OIDC flow by updating the OAuth2Auth model and the update_credential_with_tokens utility function. The implementation is straightforward and correct. My only suggestion is to update the existing unit tests to cover this new functionality, ensuring the change is robust and preventing future regressions. I've added a specific comment with a suggestion on how to update the tests.

[ryanaiagent]

Hi @guillaumeblaquiere , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Can you fix the lint error. You can use autoformat.sh.
Let us know once you have done that.

[guillaumeblaquiere]

@ryanaiagent I ran the autoformat but I didn't understand why it was related to the previous error.
Let me know if you need more actions from me;