Skip to content

fix: Escape Click’s Wrapping in adk eval help #4258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ftnext wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

fix: Escape Click’s Wrapping in adk eval help #4258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/google/adk/cli/cli_tools_click.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,6 +701,7 @@ def cli_eval(
separated list of eval names and then add that as a suffix to the eval set
file name, demarcated by a `:`.

\b
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While adding \b on its own line works to prevent re-wrapping, it will also introduce an extra newline in the help output before "For example...". This is because after stripping \b, the paragraph starts with a newline character (\n).

To fix the wrapping without adding an extra blank line, you should remove this line and instead place \b at the beginning of the following line, like this:

  \bFor example, we have `sample_eval_set_file.json` file that has following the

For example, we have `sample_eval_set_file.json` file that has following the
eval cases:
sample_eval_set_file.json:
Expand All @@ -721,6 +722,7 @@ def cli_eval(
separated list of eval names and then add that as a suffix to the eval set
file name, demarcated by a `:`.

\b
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to my previous comment, adding \b on its own line here will introduce an extra newline in the help output.

To avoid this, please remove this line and add \b to the beginning of the next line:

  \bFor example, we have `sample_eval_set_id` that has following the eval cases:

For example, we have `sample_eval_set_id` that has following the eval cases:
sample_eval_set_id:
|....... eval_1
Expand All @@ -729,6 +731,7 @@ def cli_eval(
|....... eval_4
|....... eval_5

\b
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to my other comments, adding \b on its own line here will introduce an extra newline in the help output.

To avoid this, please remove this line and add \b to the beginning of the next line:

  \bIf we did:

If we did:
sample_eval_set_id:eval_1,eval_2,eval_3

Expand Down