Skip to content

Conversation

@jschwe
Copy link
Contributor

@jschwe jschwe commented Dec 1, 2024

Fixes a "region out-of-bounds" assertion failure in StrictSubstr when running bloaty on a Rust shared library compiled for aarch64-unknown-linux-ohos.

When remaining_ is just the "\0" character, we are done and should return.

Fixes a "region out-of-bounds" assertion failure in
StrictSubstr.

When `remaining_` is just the "\0" character we are
done and should return.
@EricRahm
Copy link
Collaborator

EricRahm commented Nov 5, 2025

@jschwe Thanks for the proposed fix! I rebased and tested this and it looks like it regresses a few tests:

Failed Tests (5):
  bloaty :: dwarf/debug_info/dw_form_line_strp.test
  bloaty :: dwarf/debug_info/ignore-declarations.test
  bloaty :: dwarf/debug_info/pcpair-incomplete.test
  bloaty :: dwarf/debug_info/pcpair.test
  bloaty :: dwarf/range_lists/base-addr-selection.test

I'm guessing the fix is a bit more nuanced. It might be worth filing an issue including a binary that reproduces to track this.

If you're up for it we'd want to add a lit test to reproduce the issue and a rebased and updated fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants