This repository was archived by the owner on Aug 25, 2025. It is now read-only.
Revert "Update dependencies to support Generics"#365
Merged
Conversation
This reverts commit 4aee85e.
|
oof, looks like we'll have to merge #356 first, if we decide to move up to 1.18 |
jayzhuang
approved these changes
Jun 20, 2022
|
@jayzhuang any plans to merge #356 ? |
|
Also curious on the status of getting generic support back into wire |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #360
Build tests are failing
internal/wire/copyast.go:267: undefined: ast.IndexListExprThey still are using go1.17 so they'll need to first be updated to go1.18.