[pointer] Add generic projection/cast framework #2854
Conversation
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a project_ptr_inner! macro for projecting PtrInner to a field, along with a comprehensive test suite. The macro implementation appears sound, but I've found a few issues. There are a couple of TODO comments that should be FIXMEs according to the repository's style guide. More importantly, one of the new tests appears to rely on a pointer cast (*mut [u8] to *mut [()]) that is documented as a compile-time error in Rust, which could lead to undefined behavior or compiler-specific dependencies.
joshlf
force-pushed
the
G57b42ad4ff767a765f9b4ac149aa1c19d3796711
branch
from
8a4e49b to
09d0afd
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2854 +/- ##
==========================================
- Coverage 91.94% 91.90% -0.05%
==========================================
Files 20 20
Lines 5824 5778 -46
==========================================
- Hits 5355 5310 -45
+ Misses 469 468 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
G57b42ad4ff767a765f9b4ac149aa1c19d3796711
branch
9 times, most recently
from
6450ea0 to
39e9cfb
Compare
joshlf
changed the base branch from
main
to
G9e7039c715e1ec53e6d860909bb0d618898fd46b
joshlf
force-pushed
the
G57b42ad4ff767a765f9b4ac149aa1c19d3796711
branch
4 times, most recently
from
db34e90 to
9a8da36
Compare
joshlf
changed the title
project_ptr_inner! helperCast framework
joshlf
force-pushed
the
G57b42ad4ff767a765f9b4ac149aa1c19d3796711
branch
3 times, most recently
from
7da501e to
e199498
Compare
jswrenn
force-pushed
the
G9e7039c715e1ec53e6d860909bb0d618898fd46b
branch
from
4e3e874 to
898e717
Compare
joshlf
force-pushed
the
G9e7039c715e1ec53e6d860909bb0d618898fd46b
branch
from
898e717 to
e28215f
Compare
joshlf
force-pushed
the
G57b42ad4ff767a765f9b4ac149aa1c19d3796711
branch
from
e199498 to
c37397b
Compare
joshlf
force-pushed
the
G9e7039c715e1ec53e6d860909bb0d618898fd46b
branch
from
e28215f to
122da00
Compare
joshlf
force-pushed
the
G57b42ad4ff767a765f9b4ac149aa1c19d3796711
branch
from
c37397b to
21652c0
Compare
joshlf
force-pushed
the
G57b42ad4ff767a765f9b4ac149aa1c19d3796711
branch
from
28bb18f to
68e740c
Compare
joshlf
force-pushed
the
G03596047b3e8a9931799295d1e707540561c4e46
branch
from
eb73d5a to
dd41efa
Compare
joshlf
force-pushed
the
G57b42ad4ff767a765f9b4ac149aa1c19d3796711
branch
from
68e740c to
1cdac73
Compare
joshlf
force-pushed
the
G03596047b3e8a9931799295d1e707540561c4e46
branch
2 times, most recently
from
5d01996 to
86b13be
Compare
joshlf
force-pushed
the
G57b42ad4ff767a765f9b4ac149aa1c19d3796711
branch
from
1cdac73 to
1882a99
Compare
joshlf
force-pushed
the
G03596047b3e8a9931799295d1e707540561c4e46
branch
from
86b13be to
fd4aaf7
Compare
joshlf
force-pushed
the
G57b42ad4ff767a765f9b4ac149aa1c19d3796711
branch
2 times, most recently
from
b66acbc to
e01b45d
Compare
joshlf
force-pushed
the
G03596047b3e8a9931799295d1e707540561c4e46
branch
2 times, most recently
from
28cf083 to
1c5cebf
Compare
joshlf
force-pushed
the
G57b42ad4ff767a765f9b4ac149aa1c19d3796711
branch
from
e01b45d to
fc0665c
Compare
joshlf
force-pushed
the
G57b42ad4ff767a765f9b4ac149aa1c19d3796711
branch
11 times, most recently
from
ed795f7 to
c5bd760
Compare
Add `unsafe trait Project` and `unsafe trait Cast: Project`. `Cast` is implemented for any address-preserving cast, while `Project` generalizes to conversions which may not preserve the address of the referent (ie, field projections). Use these (mostly `Cast`, but some `Project`) to unify `PtrInner`/`Ptr` casts, field projections, and `SizeEq` casts. Replace a good amount of unsafe derive-generated code with uses of this machinery. Makes progress on #196 Closes #2856 gherrit-pr-id: G57b42ad4ff767a765f9b4ac149aa1c19d3796711
joshlf
force-pushed
the
G57b42ad4ff767a765f9b4ac149aa1c19d3796711
branch
from
c5bd760 to
f201bec
Compare
|
Replaced by #2860 |
2 participants
Add
unsafe trait Projectandunsafe trait Cast: Project.Castisimplemented for any address-preserving cast, while
Projectgeneralizesto conversions which may not preserve the address of the referent (ie,
field projections). Use these (mostly
Cast, but someProject) tounify
PtrInner/Ptrcasts, field projections, andSizeEqcasts.Replace a good amount of unsafe derive-generated code with uses of this
machinery.
Makes progress on #196
Closes #2856
Latest Update: v54 — Compare vs v53
📚 Full Patch History
Links show the diff between the row version and the column version.