Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Mar 14, 2025

This PR adds more showcase integration tests for LRO:

Towards googleapis/python-api-core#809
Towards b/403274054

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 14, 2025
@parthea parthea force-pushed the fix-lro-no-result branch from a1cba52 to 23a42ea Compare March 14, 2025 00:38
@parthea parthea force-pushed the fix-lro-no-result branch from 05044df to 5c51106 Compare March 14, 2025 01:16
@parthea parthea marked this pull request as ready for review March 14, 2025 01:22
@parthea parthea requested a review from a team as a code owner March 14, 2025 01:22
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2025
@parthea parthea changed the title tests: add more tests for lro tests: add more tests for LRO Mar 14, 2025
Comment on lines +388 to +395

# For prototyping purposes only.
# Remove once https://github.com/googleapis/python-api-core/pull/810 is released
session.install(
"google-api-core @ git+https://github.com/googleapis/python-api-core.git@fix-lro-no-result",
"--ignore-installed",
)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove once googleapis/python-api-core#810 is released

Comment on lines +426 to +431
# For prototyping purposes only.
# Remove once https://github.com/googleapis/python-api-core/pull/810 is released
session.install(
"google-api-core @ git+https://github.com/googleapis/python-api-core.git@fix-lro-no-result",
"--ignore-installed",
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove once googleapis/python-api-core#810 is released

@parthea parthea closed this Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants