-
Notifications
You must be signed in to change notification settings - Fork 548
chore: Cleanup skipped apiary APIs. #3098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: Cleanup skipped apiary APIs. #3098
Conversation
Summary of ChangesHello @robertvoinescu-work, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the API generation process by updating the C# GAPIC generator to a newer version. Concurrently, it cleans up the list of excluded services, allowing several previously problematic APIs to now be processed. This change streamlines the development workflow by ensuring more APIs can be generated without manual intervention, reflecting improvements in the generator or resolution of API-specific issues. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a straightforward cleanup that removes several services from the exclusion list, allowing them to be generated. This is a positive change. The corresponding version bump for the C# generator is also appropriate. I have one minor suggestion regarding code formatting for improved cleanliness.
| # from any script that wants to invoke the C#-based generator. | ||
|
|
||
| declare -r GAPIC_GENERATOR_VERSION=1.4.29 | ||
| declare -r GAPIC_GENERATOR_VERSION=1.4.36 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this new version as it contains a fix for aiplatform.v1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MERGING BLOCKED: We will need to release this version of the Gapic generator first.
API generation has been verified locally for all those removed from
ExcludedServices.jsonb/462579583