Skip to content

Conversation

@robertvoinescu-work
Copy link
Contributor

@robertvoinescu-work robertvoinescu-work commented Dec 29, 2025

API generation has been verified locally for all those removed from ExcludedServices.json

b/462579583

@robertvoinescu-work robertvoinescu-work requested a review from a team as a code owner December 29, 2025 16:22
@gemini-code-assist
Copy link

Summary of Changes

Hello @robertvoinescu-work, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the API generation process by updating the C# GAPIC generator to a newer version. Concurrently, it cleans up the list of excluded services, allowing several previously problematic APIs to now be processed. This change streamlines the development workflow by ensuring more APIs can be generated without manual intervention, reflecting improvements in the generator or resolution of API-specific issues.

Highlights

  • C# GAPIC Generator Version Update: The version of the C# GAPIC generator has been updated from 1.4.29 to 1.4.36.
  • API Exclusion List Cleanup: Several APIs, including various versions of Metastore, Content Warehouse, Policy Simulator, AI Platform, and Composer, have been removed from the ExcludedServices.json list, indicating that previous generation issues have been resolved.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a straightforward cleanup that removes several services from the exclusion list, allowing them to be generated. This is a positive change. The corresponding version bump for the C# generator is also appropriate. I have one minor suggestion regarding code formatting for improved cleanliness.

# from any script that wants to invoke the C#-based generator.

declare -r GAPIC_GENERATOR_VERSION=1.4.29
declare -r GAPIC_GENERATOR_VERSION=1.4.36
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this new version as it contains a fix for aiplatform.v1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MERGING BLOCKED: We will need to release this version of the Gapic generator first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant