feat: support ability to set universe domain in ServiceAccountJwtAccessCredentials #1754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogle-auth-library-java into sajwtcreds-universe-domain
lqiu96
reviewed
May 28, 2025
oauth2_http/java/com/google/auth/oauth2/ServiceAccountJwtAccessCredentials.java
Show resolved
Hide resolved
lqiu96
reviewed
May 28, 2025
oauth2_http/java/com/google/auth/oauth2/ServiceAccountJwtAccessCredentials.java
Show resolved
Hide resolved
lqiu96
reviewed
May 28, 2025
oauth2_http/java/com/google/auth/oauth2/ServiceAccountJwtAccessCredentials.java
Show resolved
Hide resolved
lqiu96
reviewed
May 28, 2025
oauth2_http/java/com/google/auth/oauth2/ServiceAccountJwtAccessCredentials.java
Show resolved
Hide resolved
lqiu96
reviewed
May 28, 2025
oauth2_http/java/com/google/auth/oauth2/ServiceAccountJwtAccessCredentials.java
Show resolved
Hide resolved
…ogle-auth-library-java into sajwtcreds-universe-domain
|
mpeddada1
added
kokoro:run
yoshi-kokoro
removed
kokoro:run
lqiu96
approved these changes
May 28, 2025
svc-squareup-copybara
pushed a commit
to cashapp/misk
that referenced
this pull request
May 29, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.auth:google-auth-library-oauth2-http](https://github.com/googleapis/google-auth-library-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.35.0` -> `1.36.0` | | [com.google.auth:google-auth-library-credentials](https://github.com/googleapis/google-auth-library-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.35.0` -> `1.36.0` | | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | minor | `2.17.0` -> `2.18.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.51` -> `2.31.52` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.51` -> `2.31.52` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.51` -> `2.31.52` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.51` -> `2.31.52` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.51` -> `2.31.52` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.51` -> `2.31.52` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.51` -> `2.31.52` | --- ### Release Notes <details> <summary>googleapis/google-auth-library-java (com.google.auth:google-auth-library-oauth2-http)</summary> ### [`v1.36.0`](https://github.com/googleapis/google-auth-library-java/blob/HEAD/CHANGELOG.md#1360-2025-05-28) ##### Features - Support ability to set universe domain in ServiceAccountJwtAccessCredentials ([#​1754](googleapis/google-auth-library-java#1754)) ([919ae32](googleapis/google-auth-library-java@919ae32)) ##### Bug Fixes - IdTokenCredentials should fetch license id claim when requested ([#​1450](googleapis/google-auth-library-java#1450)) ([c5648a5](googleapis/google-auth-library-java@c5648a5)) - Update approval_prompt=force to prompt=consent ([#​1752](googleapis/google-auth-library-java#1752)) ([4543d04](googleapis/google-auth-library-java@4543d04)) </details> <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.18.0`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-2180) - \[Breaking]: update min support AGP version to 8.3. - \[Feat]: Allow excluding violations by regex patterns. - \[Feat]: add `ProviderConvertible` support. - \[Feat]: add support for Activity `theme` in `AndroidManifest.xml` - \[Feat]: Android merged manifests are now treated as runtime (not compile-time) requirements. - \[Feat]: detect code source files that live outside of src/main as an AGP feature being used. - \[Fix]: detect class references in the base package. - \[Fix]: detect constants defined in Kotlin companion objects. - \[Fix]: detect androidTest source set as a test source-set. - \[Fix]: set android dependencies weight to 100. - \[Fix]: also check for com.android.test. - \[Chore]: use Gradle 8.14. - \[Chore]: `kotlin.metadata.jvm` no longer needs to be non-transitive, since bumping to K2 for this project. - \[Chore]: fix snapshot publishing by making task dependency more lazy. - \[Chore]: update badge to point to actual workflow. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: a5422211f14b730131ded613b3a52ab141771b9e
zhumin8
pushed a commit
to googleapis/sdk-platform-java
that referenced
this pull request
May 30, 2025
…entials (#3806) Follow-up PR to googleapis/google-auth-library-java#1754 For java-bigtable's use case, when GOOGLE_APPLICATION_CREDENTIALS is set to a service account's JSON path, these lines get exercised when creating `ServiceAccountJwtAccessCredentials`: https://github.com/googleapis/sdk-platform-java/blob/49a7ae50071e75fe0d161a4eb9360a4fe4e6147b/gax-java/gax/src/main/java/com/google/api/gax/core/GoogleCredentialsProvider.java#L82-L92 See https://github.com/mpeddada1/sa-universe-domain for full test setup.
lqiu96
pushed a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Jun 10, 2025
…entials (#3806) Follow-up PR to googleapis/google-auth-library-java#1754 For java-bigtable's use case, when GOOGLE_APPLICATION_CREDENTIALS is set to a service account's JSON path, these lines get exercised when creating `ServiceAccountJwtAccessCredentials`: https://github.com/googleapis/sdk-platform-java/blob/49a7ae50071e75fe0d161a4eb9360a4fe4e6147b/gax-java/gax/src/main/java/com/google/api/gax/core/GoogleCredentialsProvider.java#L82-L92 See https://github.com/mpeddada1/sa-universe-domain for full test setup.
lqiu96
pushed a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Aug 21, 2025
…entials (#3806) Follow-up PR to googleapis/google-auth-library-java#1754 For java-bigtable's use case, when GOOGLE_APPLICATION_CREDENTIALS is set to a service account's JSON path, these lines get exercised when creating `ServiceAccountJwtAccessCredentials`: https://github.com/googleapis/sdk-platform-java/blob/49a7ae50071e75fe0d161a4eb9360a4fe4e6147b/gax-java/gax/src/main/java/com/google/api/gax/core/GoogleCredentialsProvider.java#L82-L92 See https://github.com/mpeddada1/sa-universe-domain for full test setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/googleapis/sdk-platform-java/blob/49a7ae50071e75fe0d161a4eb9360a4fe4e6147b/gax-java/gax/src/main/java/com/google/api/gax/core/GoogleCredentialsProvider.java#L82-L92
Once this PR is merged, we need to update auth-library-java in sdk-platform-java and merge googleapis/sdk-platform-java#3806
See https://github.com/mpeddada1/sa-universe-domain for full test setup.