feat: Add TrustBoundaries support for ExternalAccounts. #1836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and header value. # Conflicts: # oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java # oauth2_http/java/com/google/auth/oauth2/GoogleCredentials.java # oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java # Conflicts: # oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java # oauth2_http/java/com/google/auth/oauth2/GoogleCredentials.java # oauth2_http/java/com/google/auth/oauth2/ImpersonatedCredentials.java # oauth2_http/java/com/google/auth/oauth2/OAuth2Credentials.java # oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java # oauth2_http/java/com/google/auth/oauth2/TrustBoundary.java
…e trust boundary enabler env variable
…ents regarding a separate mock for trust boundary.
vverman
force-pushed
the
feat/trust-boundary-external-account
branch
from
fb18c0c to
458bad4
Compare
vverman
added
the
do not merge
nbayati
reviewed
Oct 30, 2025
oauth2_http/java/com/google/auth/oauth2/ExternalAccountCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ExternalAccountCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ExternalAccountCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java
Outdated
Show resolved
Hide resolved
…s universe domain.
nbayati
reviewed
Oct 30, 2025
oauth2_http/javatests/com/google/auth/oauth2/ExternalAccountAuthorizedUserCredentialsTest.java
Outdated
Show resolved
Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/ExternalAccountAuthorizedUserCredentialsTest.java
Outdated
Show resolved
Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/MockTokenServerTransport.java
Outdated
Show resolved
Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/ExternalAccountAuthorizedUserCredentialsTest.java
Outdated
Show resolved
Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/ExternalAccountCredentialsTest.java
Outdated
Show resolved
Hide resolved
lqiu96
reviewed
Oct 31, 2025
oauth2_http/java/com/google/auth/oauth2/ExternalAccountAuthorizedUserCredentials.java
Show resolved
Hide resolved
lqiu96
reviewed
Oct 31, 2025
oauth2_http/java/com/google/auth/oauth2/ExternalAccountAuthorizedUserCredentials.java
Outdated
Show resolved
Hide resolved
lqiu96
reviewed
Oct 31, 2025
oauth2_http/java/com/google/auth/oauth2/ExternalAccountAuthorizedUserCredentials.java
Outdated
Show resolved
Hide resolved
lqiu96
reviewed
Oct 31, 2025
oauth2_http/java/com/google/auth/oauth2/ExternalAccountCredentials.java
Outdated
Show resolved
Hide resolved
lqiu96
reviewed
Oct 31, 2025
oauth2_http/java/com/google/auth/oauth2/ExternalAccountCredentials.java
Outdated
Show resolved
Hide resolved
lqiu96
reviewed
Oct 31, 2025
oauth2_http/java/com/google/auth/oauth2/ExternalAccountCredentials.java
Outdated
Show resolved
Hide resolved
lqiu96
reviewed
Oct 31, 2025
…tion and format changes.
lqiu96
reviewed
Nov 3, 2025
oauth2_http/java/com/google/auth/oauth2/ExternalAccountAuthorizedUserCredentials.java
Outdated
Show resolved
Hide resolved
lqiu96
reviewed
Nov 3, 2025
oauth2_http/java/com/google/auth/oauth2/ExternalAccountCredentials.java
Outdated
Show resolved
Hide resolved
Member
|
I think things generally LGTM. I will do a second pass for the tests below. |
nbayati
reviewed
Nov 3, 2025
oauth2_http/java/com/google/auth/oauth2/ExternalAccountCredentials.java
Outdated
Show resolved
Hide resolved
product-auto-label
bot
added
size: xl
vverman
force-pushed
the
feat/trust-boundary-external-account
branch
from
01eb20d to
2071071
Compare
product-auto-label
bot
added
size: l
lqiu96
reviewed
Nov 5, 2025
lqiu96
reviewed
Nov 5, 2025
oauth2_http/javatests/com/google/auth/oauth2/AwsCredentialsTest.java
Outdated
Show resolved
Hide resolved
lqiu96
reviewed
Nov 5, 2025
lqiu96
reviewed
Nov 5, 2025
oauth2_http/java/com/google/auth/oauth2/ExternalAccountAuthorizedUserCredentials.java
Outdated
Show resolved
Hide resolved
lqiu96
approved these changes
Nov 5, 2025
Member
lqiu96
left a comment
lqiu96
left a comment
There was a problem hiding this comment.
LGTM. I added a few nits that may need additional code changes (feel free to resolve if it's not possible). I can re-approve afterwards.
vverman
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logic and unit tests for trust boundary for external accounts. This PR covers
This PR is a followup of the initial PR for Trust Boundaries for Service accounts.