Skip to content

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Nov 6, 2025

See b/458269866 for more information.

Retrieving the default SA principal was intended to help customers when getting credential info via getCredentialInfo(). This introduced some behavior breaking changes internally. Since getCredentialInfo() is intended to return info on a best-effort basis, users can call getAccount manually to get the default SA value.

Reverts a few changes in #1791

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 6, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Nov 6, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@lqiu96 lqiu96 marked this pull request as ready for review November 6, 2025 18:09
@lqiu96 lqiu96 requested review from a team as code owners November 6, 2025 18:09
@lqiu96 lqiu96 requested a review from zhumin8 November 6, 2025 18:10
@lqiu96 lqiu96 merged commit a65c22d into main Nov 6, 2025
26 of 27 checks passed
@lqiu96 lqiu96 deleted the revert-sa-call branch November 6, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants