-
Notifications
You must be signed in to change notification settings - Fork 345
feat: support Python 3.14 #1822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There is still no samples test for python 3.14, nor 3.13 |
|
Have added the 3.14 samples test, but still have unit tests to fix |
| http = aiohttp.ClientSession(auto_decompress=True) | ||
| with pytest.raises(ValueError): | ||
| aiohttp_requests.Request(http) | ||
| await aiohttp_requests.Request(http) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why were these tests changed to async?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks correct to me. My initial thought is that this should have been async based on this code
google-auth-library-python/google/auth/transport/_aiohttp_requests.py
Lines 122 to 153 in 9be6918
| class Request(transport.Request): | |
| """Requests request adapter. | |
| This class is used internally for making requests using asyncio transports | |
| in a consistent way. If you use :class:`AuthorizedSession` you do not need | |
| to construct or use this class directly. | |
| This class can be useful if you want to manually refresh a | |
| :class:`~google.auth.credentials.Credentials` instance:: | |
| import google.auth.transport.aiohttp_requests | |
| request = google.auth.transport.aiohttp_requests.Request() | |
| credentials.refresh(request) | |
| Args: | |
| session (aiohttp.ClientSession): An instance :class:`aiohttp.ClientSession` used | |
| to make HTTP requests. If not specified, a session will be created. | |
| .. automethod:: __call__ | |
| """ | |
| def __init__(self, session=None): | |
| # TODO: Use auto_decompress property for aiohttp 3.7+ | |
| if session is not None and session._auto_decompress: | |
| raise exceptions.InvalidOperation( | |
| "Client sessions with auto_decompress=True are not supported." | |
| ) | |
| self.session = session | |
| async def __call__( |
|
Sample tests for 3.14 are blocked on GoogleCloudPlatform/python-docs-samples#13596 |
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator:latest <details><summary>google-auth: 2.44.0</summary> ## [2.44.0](v2.43.0...v2.44.0) (2025-12-12) ### Features * MDS connections use mTLS (#1856) ([0387bb9](0387bb95)) * support Python 3.14 (#1822) ([0f7097e](0f7097e7)) * add ecdsa p-384 support (#1872) ([39c381a](39c381a5)) * Add shlex to correctly parse executable commands with spaces (#1855) ([cf6fc3c](cf6fc3cc)) * Implement token revocation in STS client and add revoke() metho… (#1849) ([d563898](d5638986)) ### Bug Fixes * Add temporary patch to workload cert logic to accomodate Cloud Run mis-configuration (#1880) ([78de790](78de7907)) * Delegate workload cert and key default lookup to helper function (#1877) ([b0993c7](b0993c7e)) * Use public refresh method for source credentials in ImpersonatedCredentials (#1884) ([e0c3296](e0c3296f)) </details>
No description provided.