Skip to content

Conversation

@daniel-sanche
Copy link
Collaborator

@daniel-sanche daniel-sanche commented Jan 6, 2026

There were recently some type annotation changes that weren't compatible with python 3.8. This PR fixes those, and adds back 3.8 tests using github actions

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a regression in Python 3.8 support by restoring the necessary test configurations and making a minor type import adjustment. The primary goal is to ensure that the project is fully tested and functional on Python 3.8, aligning with its intended compatibility.

Highlights

  • Python 3.8 Support: Re-enabled testing for Python 3.7 and 3.8 by adding them back to the UNIT_TEST_PYTHON_VERSIONS list in noxfile.py.
  • Type Hinting Compatibility: Updated the import of Sequence from collections.abc to typing in google/auth/_default.py for broader compatibility across Python versions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to restore Python 3.8 support. The change in google/auth/_default.py to use typing.Sequence is correct for ensuring compatibility. In noxfile.py, Python 3.7 and 3.8 are correctly added to the list of unit test versions. However, a necessary change to the nox.options.sessions list seems to have been missed, which would prevent the newly added tests for Python 3.7 and 3.8 from running by default. I've added a comment with details.

Copy link

@cashpilotthrive-hue cashpilotthrive-hue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming all

@daniel-sanche daniel-sanche marked this pull request as ready for review January 6, 2026 18:21
@daniel-sanche daniel-sanche requested review from a team as code owners January 6, 2026 18:21
parthea
parthea previously approved these changes Jan 6, 2026
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming that 3.7 will be removed prior to releasing

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@daniel-sanche daniel-sanche merged commit 60dc200 into main Jan 6, 2026
17 checks passed
@daniel-sanche daniel-sanche deleted the fix-38 branch January 6, 2026 20:07
daniel-sanche added a commit that referenced this pull request Jan 6, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v1.0.1
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209
<details><summary>google-auth: 2.47.0</summary>

##
[2.47.0](v2.46.0...v2.47.0)
(2026-01-06)

### Features

* drop `cachetools` dependency in favor of simple local implementation
(#1590)
([5c07e1c](5c07e1c4))

### Bug Fixes

* Python 3.8 support (#1918)
([60dc200](60dc2001))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants