-
Notifications
You must be signed in to change notification settings - Fork 346
fix: Python 3.8 support #1918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Python 3.8 support #1918
Conversation
Summary of ChangesHello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a regression in Python 3.8 support by restoring the necessary test configurations and making a minor type import adjustment. The primary goal is to ensure that the project is fully tested and functional on Python 3.8, aligning with its intended compatibility. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to restore Python 3.8 support. The change in google/auth/_default.py to use typing.Sequence is correct for ensuring compatibility. In noxfile.py, Python 3.7 and 3.8 are correctly added to the list of unit test versions. However, a necessary change to the nox.options.sessions list seems to have been missed, which would prevent the newly added tests for Python 3.7 and 3.8 from running by default. I've added a comment with details.
cashpilotthrive-hue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming all
parthea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming that 3.7 will be removed prior to releasing
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v1.0.1 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209 <details><summary>google-auth: 2.47.0</summary> ## [2.47.0](v2.46.0...v2.47.0) (2026-01-06) ### Features * drop `cachetools` dependency in favor of simple local implementation (#1590) ([5c07e1c](5c07e1c4)) ### Bug Fixes * Python 3.8 support (#1918) ([60dc200](60dc2001)) </details>
There were recently some type annotation changes that weren't compatible with python 3.8. This PR fixes those, and adds back 3.8 tests using github actions