API Implementation for ResumeAppendableObjectUpload #15816
Conversation
Summary of ChangesHello @rajeevpodar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a new asynchronous API, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new overload for ResumeAppendableObjectUpload that accepts a google::storage::v2::BidiWriteObjectRequest, enhancing the API's flexibility. The implementation is sound and includes a corresponding test case. My review focuses on an opportunity to refactor duplicated code for better maintainability and a minor documentation consistency fix.
google/cloud/storage/async/client.h
Outdated
| * @param opts options controlling the behaviour of this RPC, for example the | ||
| * application may change the retry policy. |
There was a problem hiding this comment.
There's a spelling inconsistency. This comment uses "behaviour" (British English), but other comments in this file and codebase use "behavior" (American English). For consistency, it's best to use one spelling throughout the project.
* @param opts options controlling the behavior of this RPC, for example the
* application may change the retry policy.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15816 +/- ##
==========================================
- Coverage 92.95% 92.94% -0.01%
==========================================
Files 2458 2458
Lines 227589 227628 +39
==========================================
+ Hits 211559 211575 +16
- Misses 16030 16053 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ppendableObjectUpload` overload.
rajeevpodar
changed the title
| * recovery from transient failures. | ||
| * | ||
| * @param request the request contents, it must include the bucket name, | ||
| * object name, and generation. Many other fields are optional. |
There was a problem hiding this comment.
Forgot to mention, append_object_spec is required, write_object_spec would not work here.
2 participants
This PR adds a new overload for
ResumeAppendableObjectUploadthat accepts agoogle::storage::v2::BidiWriteObjectRequest. This allows callers to set specific options on the request, such asflush: true, which were previously inaccessible via the existing overload.The existing
ResumeAppendableObjectUploadoverload has been refactored to delegate to this new overload, ensuring consistent behavior and reducing code duplication.