Skip to content

Bigtable dynamic channel pool prototype #15819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
scotthart wants to merge 11 commits into
base: main
Choose a base branch
from
+1,358 −32
Draft

Bigtable dynamic channel pool prototype #15819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e7a2773
initial implementation
scotthart Dec 6, 2025
984599c
working integration tests with new stub and pool
scotthart Dec 6, 2025
4f26155
add and remove implemented
scotthart Dec 7, 2025
4b11b16
fixed or percentage channel add
scotthart Dec 8, 2025
97d4f82
undo some of the renaming
scotthart Dec 8, 2025
434a1a8
remove printf from generated stub
scotthart Dec 8, 2025
a4503f6
make refresh_state a member of channel pool
scotthart Dec 8, 2025
c2d51e4
kinda working with iota iterators
scotthart Dec 9, 2025
81631aa
connection refresh callback sets status
scotthart Dec 10, 2025
e5a1ff8
factor out EvictBadChannels
scotthart Dec 10, 2025
59d22fb
average per minute with tests
scotthart Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ci/cloudbuild/builds/integration-production.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export CC=clang
export CXX=clang++

mapfile -t args < <(bazel::common_args)
io::run bazel test "${args[@]}" --test_tag_filters=-integration-test "${BAZEL_TARGETS[@]}"
#io::run bazel test "${args[@]}" --test_tag_filters=-integration-test "${BAZEL_TARGETS[@]}"

excluded_rules=(
"-//examples:grpc_credential_types"
Expand All @@ -39,8 +39,8 @@ excluded_rules=(
"-//google/cloud/storagecontrol:v2_samples_storage_control_anywhere_cache_samples"
)

# --test_filter="*ReadRowsAllRows*" --test_timeout=30 \
io::log_h2 "Running the integration tests against prod"
mapfile -t integration_args < <(integration::bazel_args)
io::run bazel test "${args[@]}" "${integration_args[@]}" \
--cache_test_results="auto" --test_tag_filters="integration-test,-ud-only" \
-- "${BAZEL_TARGETS[@]}" "${excluded_rules[@]}"
io::run bazel test "${args[@]}" "${integration_args[@]}" --test_output=all \
//google/cloud/bigtable/tests:data_integration_test
2 changes: 1 addition & 1 deletion ci/cloudbuild/builds/lib/integration.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ function integration::bazel_args() {

# Integration tests are inherently flaky. Make up to three attempts to get the
# test passing.
args+=(--flaky_test_attempts=3)
#args+=(--flaky_test_attempts=3)

args+=(
# Common settings
Expand Down
5 changes: 5 additions & 0 deletions google/cloud/bigtable/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,8 @@ add_library(
internal/bigtable_logging_decorator.h
internal/bigtable_metadata_decorator.cc
internal/bigtable_metadata_decorator.h
internal/bigtable_random_two_least_used_decorator.cc
internal/bigtable_random_two_least_used_decorator.h
internal/bigtable_round_robin_decorator.cc
internal/bigtable_round_robin_decorator.h
internal/bigtable_stub.cc
Expand Down Expand Up @@ -194,6 +196,8 @@ add_library(
internal/default_row_reader.h
internal/defaults.cc
internal/defaults.h
internal/dynamic_channel_pool.cc
internal/dynamic_channel_pool.h
internal/google_bytes_traits.cc
internal/google_bytes_traits.h
internal/legacy_async_bulk_apply.cc
Expand Down Expand Up @@ -491,6 +495,7 @@ if (BUILD_TESTING)
internal/data_tracing_connection_test.cc
internal/default_row_reader_test.cc
internal/defaults_test.cc
internal/dynamic_channel_pool_test.cc
internal/google_bytes_traits_test.cc
internal/legacy_async_bulk_apply_test.cc
internal/legacy_async_row_reader_test.cc
Expand Down
1 change: 1 addition & 0 deletions google/cloud/bigtable/bigtable_client_unit_tests.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ bigtable_client_unit_tests = [
"internal/data_tracing_connection_test.cc",
"internal/default_row_reader_test.cc",
"internal/defaults_test.cc",
"internal/dynamic_channel_pool_test.cc",
"internal/google_bytes_traits_test.cc",
"internal/legacy_async_bulk_apply_test.cc",
"internal/legacy_async_row_reader_test.cc",
Expand Down
4 changes: 4 additions & 0 deletions google/cloud/bigtable/google_cloud_cpp_bigtable.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ google_cloud_cpp_bigtable_hdrs = [
"internal/bigtable_channel_refresh.h",
"internal/bigtable_logging_decorator.h",
"internal/bigtable_metadata_decorator.h",
"internal/bigtable_random_two_least_used_decorator.h",
"internal/bigtable_round_robin_decorator.h",
"internal/bigtable_stub.h",
"internal/bigtable_stub_factory.h",
Expand All @@ -95,6 +96,7 @@ google_cloud_cpp_bigtable_hdrs = [
"internal/data_tracing_connection.h",
"internal/default_row_reader.h",
"internal/defaults.h",
"internal/dynamic_channel_pool.h",
"internal/google_bytes_traits.h",
"internal/legacy_async_bulk_apply.h",
"internal/legacy_async_row_reader.h",
Expand Down Expand Up @@ -204,6 +206,7 @@ google_cloud_cpp_bigtable_srcs = [
"internal/bigtable_channel_refresh.cc",
"internal/bigtable_logging_decorator.cc",
"internal/bigtable_metadata_decorator.cc",
"internal/bigtable_random_two_least_used_decorator.cc",
"internal/bigtable_round_robin_decorator.cc",
"internal/bigtable_stub.cc",
"internal/bigtable_stub_factory.cc",
Expand All @@ -217,6 +220,7 @@ google_cloud_cpp_bigtable_srcs = [
"internal/data_tracing_connection.cc",
"internal/default_row_reader.cc",
"internal/defaults.cc",
"internal/dynamic_channel_pool.cc",
"internal/google_bytes_traits.cc",
"internal/legacy_async_bulk_apply.cc",
"internal/legacy_async_row_reader.cc",
Expand Down
Loading