feat(bigtable): remove deprecated RowReader constructors

[mpeddada1]

Using https://github.com/googleapis/google-cloud-cpp/blob/main/doc/deprecated.md as reference for migration guide.

Fixes #7230

[gemini-code-assist]

Summary of Changes

Hello @mpeddada1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on cleaning up the google-cloud-cpp Bigtable client library by removing previously deprecated RowReader constructors. This change streamlines the API by eliminating older, less preferred methods for reading rows and guides developers towards the current recommended approach using Table::ReadRows(...), ensuring consistency and maintainability.

Highlights

• Deprecated Constructor Removal: The pull request removes two deprecated bigtable::RowReader constructors that accepted DataClient as an argument.
• Migration Guide Update: The v3-migration-guide.md has been updated with a new section under Bigtable, advising users on the removal of these constructors and recommending the use of Table::ReadRows(...) instead.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes deprecated RowReader constructors that accept a DataClient. The change is implemented correctly by removing the constructor declarations from the header file and their implementations from the source file. The v3 migration guide has also been updated to reflect this breaking change, which is a good practice. I have one minor suggestion to improve the formatting in the migration guide.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.94%. Comparing base (929433b) to head (9e72e21).
⚠️ Report is 1 commits behind head on prepare-for-v3.0.0.

Additional details and impacted files

@@                  Coverage Diff                   @@
##           prepare-for-v3.0.0   #15840      +/-   ##
======================================================
- Coverage               92.95%   92.94%   -0.01%     
======================================================
  Files                    2454     2454              
  Lines                  227415   227401      -14     
======================================================
- Hits                   211393   211366      -27     
- Misses                  16022    16035      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.