Skip to content

impl(bigtable): remove deprecated AsyncRowReader header #15842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mpeddada1 wants to merge 6 commits into
base: prepare-for-v3.0.0
Choose a base branch
from
+17 −47
Open

impl(bigtable): remove deprecated AsyncRowReader header #15842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
152f295
impl(bigtable): remove deprecated AsyncRowReader header
mpeddada1 Dec 19, 2025
26c03c4
fix checkers
mpeddada1 Dec 19, 2025
76dc605
fix formatting
mpeddada1 Dec 19, 2025
4eceb73
add before and after
mpeddada1 Dec 20, 2025
e43e745
Merge branch 'prepare-for-v3.0.0' into async-rowreader-removal
mpeddada1 Dec 20, 2025
a81afea
run checkers
mpeddada1 Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions doc/v3-migration-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,23 @@ for (auto& row : table.ReadRows(

</details>

<details>
<summary>Removed <code>bigtable::AsyncRowReader<>::NO_ROWS_LIMIT</code>
</summary>

AsyncRowReader::NO_ROWS_LIMIT has been removed. Please use
`google::cloud::bigtable::RowReader::NO_ROWS_LIMIT` instead.

```cpp
// Before
auto limit = google::cloud::bigtable::AsyncRowReader<>::NO_ROWS_LIMIT;

// After
auto limit = google::cloud::bigtable::RowReader::NO_ROWS_LIMIT;
```

</details>

### Pubsub

### Spanner
Expand Down
1 change: 0 additions & 1 deletion google/cloud/bigtable/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ add_library(
admin_client.h
app_profile_config.cc
app_profile_config.h
async_row_reader.h
bound_query.cc
bound_query.h
bytes.cc
Expand Down
45 changes: 0 additions & 45 deletions google/cloud/bigtable/async_row_reader.h
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion google/cloud/bigtable/google_cloud_cpp_bigtable.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ google_cloud_cpp_bigtable_hdrs = [
"admin/internal/bigtable_table_admin_tracing_stub.h",
"admin_client.h",
"app_profile_config.h",
"async_row_reader.h",
"bound_query.h",
"bytes.h",
"cell.h",
Expand Down