impl(bigtable): remove deprecated client options

[mpeddada1]

For #7230

[gemini-code-assist]

Summary of Changes

Hello @mpeddada1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request completes the deprecation process for bigtable::ClientOptions and its associated CreateDefault*Client factory functions within the Bigtable client library. The changes standardize client configuration by exclusively using google::cloud::Options and Make*Client functions, aligning with the broader Google Cloud C++ client library design. The migration guide has been thoroughly updated to assist users in adapting to these changes.

Highlights

• Removal of bigtable::ClientOptions: The deprecated bigtable::ClientOptions class has been entirely removed from the Bigtable client library. Users should now configure clients using google::cloud::Options.
• Removal of CreateDefault*Client functions: The deprecated factory functions bigtable::CreateDefaultDataClient, bigtable::CreateDefaultAdminClient, and bigtable::CreateDefaultInstanceAdminClient have been removed. Their replacements are bigtable::MakeDataClient, bigtable::MakeAdminClient, and bigtable::MakeInstanceAdminClient respectively, which accept google::cloud::Options.
• Migration Guide Update: The doc/v3-migration-guide.md has been updated to provide a comprehensive mapping from the old bigtable::ClientOptions methods to their google::cloud::Options equivalents, along with example usage.
• Codebase Cleanup: All associated files, including headers, source files, and test files related to bigtable::ClientOptions and the deprecated CreateDefault*Client functions, have been removed from the codebase and build configurations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes the deprecated bigtable::ClientOptions and related factory functions, replacing their usage with google::cloud::Options. The changes are spread across the Bigtable client library, tests, and documentation. Key changes include deleting client_options.h, client_options.cc, and their corresponding test files, and removing deprecated CreateDefault...Client functions. The migration guide has been updated with detailed instructions on how to move from the old ClientOptions to the new Options framework. The changes are clean and correctly execute the planned deprecation removal. This is a great step towards modernizing the API.

[mpeddada1]

/gemini review

[gemini-code-assist]

Code Review

This pull request is a great step forward in modernizing the Bigtable client library by removing the deprecated bigtable::ClientOptions and its associated factory functions. The changes are extensive and cleanly remove the old API surface. I appreciate the thoroughness of the changes, which include updating build files, tests, and examples. The update to the migration guide is particularly well done, providing clear instructions and examples for users transitioning to the new google::cloud::Options-based configuration. Overall, this is a high-quality cleanup that improves the consistency and maintainability of the codebase.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.93%. Comparing base (600d394) to head (993a88a).

Additional details and impacted files

@@                  Coverage Diff                   @@
##           prepare-for-v3.0.0   #15843      +/-   ##
======================================================
- Coverage               92.94%   92.93%   -0.02%     
======================================================
  Files                    2454     2451       -3     
  Lines                  227401   226871     -530     
======================================================
- Hits                   211368   210838     -530     
  Misses                  16033    16033              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.