-
Notifications
You must be signed in to change notification settings - Fork 432
ci: exclude few storage integration tests #15846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @v-pratap, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to stabilize the continuous integration pipeline by temporarily excluding a set of storage integration tests that are currently causing issues. By preventing these tests from running, the CI process can proceed without being blocked, allowing developers to focus on resolving the identified problems in a separate effort. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request disables several storage integration tests to address flakiness, as tracked in issue #15845. The change is correct in its approach. I've added one suggestion to improve the comment's clarity for future maintainers, providing immediate context for why the tests are disabled.
| "-//google/cloud/storage/examples:storage_service_account_samples" | ||
| # This sample can be very long running due to creation time of AnywhereCache | ||
| "-//google/cloud/storagecontrol:v2_samples_storage_control_anywhere_cache_samples" | ||
| # TODO(#15845): Re-enable these tests once the issue is resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better context, it would be helpful to briefly state why these tests are being disabled, similar to the comments for other disabled tests in this list. This helps developers understand the reason for the exclusion without needing to navigate to the issue tracker.
| # TODO(#15845): Re-enable these tests once the issue is resolved. | |
| # TODO(#15845): Temporarily disabled due to flakiness. Re-enable once the issue is resolved. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15846 +/- ##
==========================================
+ Coverage 92.94% 92.95% +0.01%
==========================================
Files 2458 2458
Lines 227585 227585
==========================================
+ Hits 211531 211562 +31
+ Misses 16054 16023 -31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Here is the issue created for this PR: #15845