-
Notifications
You must be signed in to change notification settings - Fork 441
feat(storage): Get/Set Object contexts #15933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @xlai20, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant new feature to the Google Cloud Storage C++ client library: the ability to manage 'Object contexts'. This allows for more detailed and structured custom metadata to be stored alongside objects. The changes encompass the definition of new C++ types to mirror the API's context structure, the integration of these contexts into the existing Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for Object contexts in Google Cloud Storage, including data structures, JSON parsing/serialization, and ObjectMetadata updates. A critical logic error was identified in the ObjectCustomContextPayload equality operator, which could lead to incorrect update_time comparisons and potential unexpected behavior in applications relying on metadata equality checks. Additionally, improvements are suggested for API documentation regarding undefined behavior, addressing code duplication, and refining output formatting in a stream operator.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15933 +/- ##
========================================
Coverage 92.96% 92.97%
========================================
Files 2460 2462 +2
Lines 228901 229036 +135
========================================
+ Hits 212791 212938 +147
+ Misses 16110 16098 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7b96752 to
3569d65
Compare
b/434726762. Part 1.
This change defines the data structure of object context, and supports the
get and set of object contexts.
The data structure and naming of object context follows
ObjectContextsandObjectCustomContextPayloadproto defined instorage.proto here.
More operations on object contexts would be supported in follow-up PRs.
This change is