ci(v3): update cmake deps #15953
ci(v3): update cmake deps #15953
Conversation
Summary of ChangesHello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining the continuous integration environment by updating the Protobuf library version within several Docker build images. This ensures that the project's CI pipelines utilize the latest stable release of Protobuf, potentially incorporating bug fixes, performance improvements, or new features, and keeping the build environment current with external dependencies. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the protobuf version from v31.1 to v33.1 across eight different Dockerfiles used for CI. The change is straightforward. I've added a suggestion to improve maintainability by using an ARG variable for the version string. This would centralize the version number within each file and make future updates easier. This suggestion applies to all Dockerfiles modified in this PR.
| # ```bash | ||
| WORKDIR /var/tmp/build/protobuf | ||
| RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v31.1.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/v33.1.tar.gz | \ |
There was a problem hiding this comment.
This version string is hardcoded here and in several other Dockerfiles. To improve maintainability and simplify future updates, consider defining the protobuf version using an ARG instruction. This would allow the version to be updated in a single place within each file.
For example:
ARG PROTOBUF_VERSION=v33.1
# ...
RUN curl -fsSL https://github.com/protocolbuffers/protobuf/archive/${PROTOBUF_VERSION}.tar.gz | \
# ...This change could be applied to all Dockerfiles modified in this PR.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## prepare-for-v3.0.0 #15953 +/- ##
======================================================
+ Coverage 92.61% 92.62% +0.01%
======================================================
Files 2332 2332
Lines 213322 213322
======================================================
+ Hits 197564 197587 +23
+ Misses 15758 15735 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There are some CI errors. E.g. Could you please take a look? |
scotthart
force-pushed
the
v3_update_cmake_docker_deps
branch
from
1496f20 to
c48e5df
Compare
scotthart
merged commit 7077419
into
googleapis:prepare-for-v3.0.0
2 participants
This change is