Skip to content

Conversation

@scotthart
Copy link
Member

@scotthart scotthart commented Feb 11, 2026

This change is Reviewable

@gemini-code-assist
Copy link

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating the project's documentation and build system configurations to align with newer minimum version requirements for essential tools and third-party libraries. It reflects a shift to C++17 as the baseline standard and streamlines information by removing outdated deprecation notices and consolidating platform support details.

Highlights

  • Minimum Version Updates: The minimum required versions for CMake, Bazel, and Clang have been updated across the project's build configurations and documentation. CMake now requires 3.22, Bazel 7.0, and Clang 14.0.0.
  • C++ Standard Bump: The project's required C++ standard has been increased from C++14 to C++17, affecting both build configurations and documentation.
  • Third-Party Dependency Updates: Minimum versions for several third-party libraries, including Abseil, gRPC, libcurl, OpenSSL, nlohmann/json, Protobuf, and OpenTelemetry, have been revised in the packaging documentation.
  • Dependency Removal: The crc32c library has been removed as a direct dependency from the project's build and packaging configurations.
  • Documentation Cleanup: Outdated information regarding deprecated features has been removed from doc/deprecated.md, and the next major version mentioned has been updated to 4.x. The 'Supported Platforms' section was also removed from google/cloud/README.md.
Changelog
  • CMakeLists.txt
    • Updated cmake_minimum_required from 3.16...3.31 to 3.22...3.31.
    • Updated minimum Clang version check from 6.0 to 14.0.0.
    • Removed the MSVC-specific CMake version check.
  • README.md
    • Updated required Bazel version from 6.0 to 7.0.
    • Updated required CMake version from 3.10 to 3.22.
    • Updated required C++ Language Version from C++14 to C++17.
    • Updated required Compilers: Clang from 6.0 to 14.0.0, Apple Clang from 12 to 17.
  • doc/compile-time-configuration.md
    • Updated the default Bazel toolchain C++ standard from C++11 to C++17 and the required standard from C++14 to C++17.
    • Updated Bazel CXX options from -std=c++14 to -std=c++17.
    • Removed the 'Enabling OpenTelemetry' section and its quickstart link.
  • doc/deprecated.md
    • Updated the next major version from 3.x to 4.x.
    • Removed details for Bigtable DataClient finalization, Bigtable RowReader constructors, BigQuery BigQueryReadReadRowsStreamingUpdater, Spanner legacy admin APIs, spanner::MakeTestRow(), Storage oauth2 namespace, and common libraries v1/gcpcxxV1 aliases.
    • Removed associated issue links.
  • doc/packaging.md
    • Updated minimum versions for Abseil (20200923 -> 20250814), gRPC (1.35.x -> 1.76.x), libcurl (7.47.0 -> 7.74.0), OpenSSL (1.0.2 -> 3.0.17), nlohmann/json (3.4.0 -> 3.12.0), Protobuf (3.15.8 -> 6.33.x), and OpenTelemetry (1.9.1 -> 1.23.0).
    • Removed crc32c from the dependency list.
    • Removed footnotes related to crc32c.
    • Removed crc32c-gh link.
  • google/cloud/README.md
    • Removed the 'Supported Platforms' section, including details on OS, C++ standard, compilers, and build systems.
  • vcpkg.json
    • Removed crc32c from dependencies.
    • Changed opentelemetry-cpp from an optional dependency with a description to a direct dependency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates documentation and configuration files for the next major version. The changes include bumping minimum versions for dependencies like CMake, Bazel, and compilers, and updating the required C++ standard to C++17. Several documentation files are updated to reflect these changes, including removing obsolete deprecation notices. My review found a couple of minor inconsistencies in the documentation that could be improved for clarity. Overall, the changes look good and are consistent with a major version release.

Comment on lines 81 to 82
The default Bazel toolchain forces C++17 on Linux and macOS. `google-cloud-cpp`
requires C++17, so you will need to update the C++ standard version. You must

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This sentence is a bit confusing. It states that the default toolchain and the library both require C++17, but then says an update is needed. Suggest rephrasing for clarity.

Suggested change
The default Bazel toolchain forces C++17 on Linux and macOS. `google-cloud-cpp`
requires C++17, so you will need to update the C++ standard version. You must
`google-cloud-cpp` requires C++17. You must ensure your Bazel toolchain is
configured to use C++17 or a newer standard. You must either:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworded.

| [OpenSSL][openssl-gh] | 3.0.17 | Crypto functions for [^3] |
| [nlohmann/json][nlohmann-json-gh] | 3.12.0 | JSON for Modern C++ [^3] |
| [protobuf][protobuf-gh] | 6.33.x | Protobuf is needed for any library based on gRPC [^5] [^6] |
| [OpenTelemetry][opentelemetry-gh] | 1.23.0 | An observability framework[^7] |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With OpenTelemetry now being a required dependency, the referenced footnote [^7] is outdated as it still refers to it as an 'optional dependency'. Suggest removing the reference to avoid confusion.

Suggested change
| [OpenTelemetry][opentelemetry-gh] | 1.23.0 | An observability framework[^7] |
| [OpenTelemetry][opentelemetry-gh] | 1.23.0 | An observability framework |

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated footnote.

Copy link
Collaborator

@diegomarquezp diegomarquezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one qq

notice. These include `google/cloud/internal/`, and
`google/cloud/testing_utils/`.

## Supported Platforms
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq: Why is this section being removed? Is 3.x compatible with all common platforms?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That same information already exists in the top level README.md. It was duplicated here and didn't seem necessary to keep both.

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.62%. Comparing base (7077419) to head (56958cf).
⚠️ Report is 2 commits behind head on prepare-for-v3.0.0.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           prepare-for-v3.0.0   #15956   +/-   ##
===================================================
  Coverage               92.61%   92.62%           
===================================================
  Files                    2332     2332           
  Lines                  213322   213322           
===================================================
+ Hits                   197574   197587   +13     
+ Misses                  15748    15735   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart merged commit 0c61457 into googleapis:prepare-for-v3.0.0 Feb 11, 2026
56 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants