Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Jan 8, 2026

Remove the pytest config that treats warnings as errors when running tests. The code in packages/google-cloud-org-policy/pytest.ini is automatically generated and there is no action we can take in this repo. The long term solution to enable warnings as errors is tracked in googleapis/gapic-generator-python#1874

Only 2 packages have this configuration and both packages are automatically generated.
https://github.com/search?q=repo%3Agoogleapis%2Fgoogle-cloud-python%20path%3Apytest.ini&type=code

Fixes #15007

@parthea parthea requested review from a team as code owners January 8, 2026 20:11
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where automatically generated pytest.ini files were causing test failures by treating warnings as errors. Since these configuration files are not directly maintainable within this repository, the PR opts to remove the problematic pytest.ini file for the google-cloud-org-policy package. This ensures that tests can run without being blocked by warnings, while the underlying generation process is updated to properly handle warning configurations.

Highlights

  • Removal of pytest configuration: The pytest.ini file in packages/google-cloud-org-policy/ has been removed, which previously configured pytest to treat all warnings as errors during test execution.
  • Addressing auto-generated code limitations: This change is a temporary measure because the pytest.ini file is automatically generated, and direct modifications or fixes for the warnings cannot be made within this repository. The long-term solution is being tracked upstream in gapic-generator-python.
  • Impact on test runs: Tests for the google-cloud-org-policy package will no longer fail due to warnings being treated as errors, allowing builds to pass while the root causes of the warnings are addressed in the generator.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the pytest.ini configuration for the google-cloud-org-policy package, which was treating test warnings as errors. The justification is that this file is auto-generated and the warnings are caused by external issues being tracked separately. While this change unblocks the CI, it's important to be aware that it also removes a quality gate, potentially allowing new warnings to go unnoticed. The change is acceptable as a temporary measure.

I am having trouble creating individual review comments. Click here to see my feedback.

packages/google-cloud-org-policy/pytest.ini (1-29)

medium

Removing this configuration file disables the 'treat warnings as errors' setting for this package's tests. While this is a pragmatic solution to unblock CI given that the file is auto-generated and the underlying issues are tracked elsewhere, it does introduce a maintenance risk. New, unrelated warnings that could indicate potential issues will no longer be caught as errors. It is crucial that the long-term solution mentioned in the PR description (googleapis/gapic-generator-python#1874) is pursued to reinstate this quality gate.

@parthea parthea merged commit c0e3e9d into main Jan 8, 2026
25 of 26 checks passed
@parthea parthea deleted the parthea-patch-9 branch January 8, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

librarian release is blocked

2 participants