-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore: disable treat warnings as errors #15008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where automatically generated Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the pytest.ini configuration for the google-cloud-org-policy package, which was treating test warnings as errors. The justification is that this file is auto-generated and the warnings are caused by external issues being tracked separately. While this change unblocks the CI, it's important to be aware that it also removes a quality gate, potentially allowing new warnings to go unnoticed. The change is acceptable as a temporary measure.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/google-cloud-org-policy/pytest.ini (1-29)
Removing this configuration file disables the 'treat warnings as errors' setting for this package's tests. While this is a pragmatic solution to unblock CI given that the file is auto-generated and the underlying issues are tracked elsewhere, it does introduce a maintenance risk. New, unrelated warnings that could indicate potential issues will no longer be caught as errors. It is crucial that the long-term solution mentioned in the PR description (googleapis/gapic-generator-python#1874) is pursued to reinstate this quality gate.
Remove the pytest config that treats warnings as errors when running tests. The code in
packages/google-cloud-org-policy/pytest.iniis automatically generated and there is no action we can take in this repo. The long term solution to enable warnings as errors is tracked in googleapis/gapic-generator-python#1874Only 2 packages have this configuration and both packages are automatically generated.
https://github.com/search?q=repo%3Agoogleapis%2Fgoogle-cloud-python%20path%3Apytest.ini&type=code
Fixes #15007