feat(storage): Restart delete resumable upload config new #30882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Neha Bajaj <bajajneha27@users.noreply.github.com>
shubhangi-google
changed the title
shubhangi-google
requested review from
a team and
yoshi-approver
as code owners
cpriti-os
requested changes
Aug 27, 2025
bajajneha27
requested changes
Sep 1, 2025
| /\/CHANGELOG\.md$/, | ||
| /\/version\.rb$/, | ||
| /\/snippets\/snippet_metadata_[\w\.]+\.json$/, | ||
| /\/snippets\/snippet_metadata_[\w.]+\.json$/, |
Contributor
There was a problem hiding this comment.
Why are we making these changes?
Contributor
Author
There was a problem hiding this comment.
was getting rubocop failure due to this
| # Delete resumable upload | ||
| # @param [String] upload_id Unique Id of a resumable upload | ||
| # | ||
| # @return [Boolean,nil] Returns `true` if the resumable upload was deleted, |
Contributor
There was a problem hiding this comment.
Can we keep it consistent? Just return boolean either way.
Contributor
Author
There was a problem hiding this comment.
this is being returned from Core API , will need to modify core API to fix this
Co-authored-by: Neha Bajaj <bajajneha27@users.noreply.github.com>
Co-authored-by: Neha Bajaj <bajajneha27@users.noreply.github.com>
cpriti-os
approved these changes
Oct 10, 2025
viacheslav-rostovtsev
approved these changes
Nov 10, 2025
bajajneha27
added
the
do not merge
Contributor
|
We can't merge this PR until core PR#24234 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature to support Restart and Delete resumable upload functionality
Implementation linked with - :googleapis/google-api-ruby-client#24234 ,googleapis/google-api-ruby-client#21896, googleapis/google-api-ruby-client#23376
this PR is created as #29215 & #30510 seems to be corrupted