Skip to content

Conversation

@amanda-tarafa
Copy link
Collaborator

No description provided.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 18, 2025
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.80%. Comparing base (76070ae) to head (0f965e3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4095      +/-   ##
==========================================
+ Coverage   94.78%   94.80%   +0.01%     
==========================================
  Files         182      182              
  Lines        6885     6885              
==========================================
+ Hits         6526     6527       +1     
+ Misses        359      358       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amanda-tarafa
Copy link
Collaborator Author

Test failures are unrelated to this PR, and seem to be in some Storage tests, for example:

image

/// # use google_cloud_secretmanager_v1::client::SecretManagerService;
/// async fn sample(
/// client: &SecretManagerService
/// ) -> gax::Result<()> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think we would prefer to use the re-exported Result over gax::Result:

# use google_cloud_secretmanager_v1::Result;
async fn sample(...) -> Result<()> { ... }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants