-
Notifications
You must be signed in to change notification settings - Fork 130
chore(deps): update dependency com.google.cloud:google-cloud-bigquery-parent to v2.58.0-rc1 #4038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ | |
| <parent> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-cloud-bigquery-parent</artifactId> | ||
| <version>2.57.2-SNAPSHOT</version><!-- {x-version-update:google-cloud-bigquery:current} --> | ||
| <version>2.58.0-rc1</version><!-- {x-version-update:google-cloud-bigquery:current} --> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This parent version update is incorrect for a multi-module project where the parent is defined within the same repository. The root |
||
| </parent> | ||
| <properties> | ||
| <site.installationModule>google-cloud-bigquery</site.installationModule> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating the parent version to
2.58.0-rc1here is incorrect because the parent POM (google-cloud-bigquery-parent) is part of this same multi-module project. The version of the parent is defined in the rootpom.xmland has not been updated from2.57.2-SNAPSHOT. This inconsistency will cause the build to fail. All modules in this project should be versioned consistently.