Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmark/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<artifactId>google-cloud-bigquery-parent</artifactId>
<groupId>com.google.cloud</groupId>
<version>2.57.2-SNAPSHOT</version><!-- {x-version-update:google-cloud-bigquery:current} -->
<version>2.58.0-rc1</version><!-- {x-version-update:google-cloud-bigquery:current} -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Updating the parent version to 2.58.0-rc1 here is incorrect because the parent POM (google-cloud-bigquery-parent) is part of this same multi-module project. The version of the parent is defined in the root pom.xml and has not been updated from 2.57.2-SNAPSHOT. This inconsistency will cause the build to fail. All modules in this project should be versioned consistently.

</parent>

<properties>
Expand Down
2 changes: 1 addition & 1 deletion google-cloud-bigquery/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<parent>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-bigquery-parent</artifactId>
<version>2.57.2-SNAPSHOT</version><!-- {x-version-update:google-cloud-bigquery:current} -->
<version>2.58.0-rc1</version><!-- {x-version-update:google-cloud-bigquery:current} -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This parent version update is incorrect for a multi-module project where the parent is defined within the same repository. The root pom.xml still defines google-cloud-bigquery-parent with version 2.57.2-SNAPSHOT. This change will break the Maven build. The version update should be applied to the parent pom.xml and propagated to all modules consistently.

</parent>
<properties>
<site.installationModule>google-cloud-bigquery</site.installationModule>
Expand Down