-
Notifications
You must be signed in to change notification settings - Fork 130
chore: remove build badges #4046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @suztomo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on tidying up the project's documentation by removing outdated and no longer relevant build badge references from the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes old build badge references from the README.md file. The change is mostly correct, but it also accidentally removes the javadocs link definition, which will break existing links in the documentation. I've added a comment with a suggestion to restore this important link definition.
|
|
||
| Java is a registered trademark of Oracle and/or its affiliates. | ||
|
|
||
| [product-docs]: https://cloud.google.com/bigquery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While removing the old build badges is correct, the [javadocs] link definition was also removed. This link is used on lines 9 and 103 of this file and its removal will break the links to the client library documentation. Please add it back as it does not appear to be a build badge reference.
| [product-docs]: https://cloud.google.com/bigquery | |
| [product-docs]: https://cloud.google.com/bigquery | |
| [javadocs]: https://cloud.google.com/java/docs/reference/google-cloud-bigquery/latest/history |
b/468377909
f0eb472 to
180aedd
Compare
|
Sorry, wrong pull request. |
Removes old badge references.
b/468377909