-
Notifications
You must be signed in to change notification settings - Fork 130
chore: Enable JUnit5 Parallel Tests #4053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @lqiu96, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the testing infrastructure by migrating from JUnit 4 to JUnit 5, which significantly enhances test execution performance. Local testing indicates a speedup from approximately 3 minutes to just 30 seconds. This upgrade ensures better maintainability and leverages the latest features of the JUnit ecosystem. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request migrates the test suite from JUnit 4 to JUnit 5 and enables parallel test execution, which significantly speeds up the unit tests. The changes are extensive and mostly mechanical, including updating dependencies, annotations, and assertions. The migration to assertThrows from the try-catch-fail pattern is a great improvement for readability and conciseness. I've noted a couple of places where this pattern could be applied for consistency. Overall, this is a solid improvement to the test infrastructure.
| try { | ||
| bigquery.getTable(DATASET, "table-not-found"); | ||
| Assert.fail(); | ||
| Assertions.fail(); | ||
| } catch (BigQueryException ex) { | ||
| Assert.assertNotNull(ex.getMessage()); | ||
| Assertions.assertNotNull(ex.getMessage()); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with other test migrations in this PR, consider using Assertions.assertThrows here instead of the try-catch-fail block. This would make the test more concise and idiomatic for JUnit 5.
BigQueryException ex =
Assertions.assertThrows(
BigQueryException.class, () -> bigquery.getTable(DATASET, "table-not-found"));
Assertions.assertNotNull(ex.getMessage());| try { | ||
| bigquery.insertAll(request); | ||
| Assert.fail(); | ||
| Assertions.fail(); | ||
| } catch (BigQueryException ex) { | ||
| Assert.assertNotNull(ex.getMessage()); | ||
| Assertions.assertNotNull(ex.getMessage()); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to other tests in this file, this try-catch-fail block can be refactored to use Assertions.assertThrows for better readability and consistency with JUnit 5 practices.
BigQueryException ex =
Assertions.assertThrows(BigQueryException.class, () -> bigquery.insertAll(request));
Assertions.assertNotNull(ex.getMessage());
Follows the changes in #4052.