Skip to content

chore: Add IT for positional parameter on higher precision timestamp field #4075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lqiu96 merged 3 commits into from
Jan 21, 2026
Merged

chore: Add IT for positional parameter on higher precision timestamp field #4075

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62ec3e9
chore: Add IT for positional parameter on higher precision timestamp …
lqiu96 Jan 21, 2026
2df7a0a
chore: Fix gemini comments
lqiu96 Jan 21, 2026
c70f1f0
chore: Fix typo
lqiu96 Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 54 additions & 34 deletions ...e-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITHighPrecisionTimestamp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/
package com.google.cloud.bigquery.it;

import static com.google.common.truth.Truth.assertThat;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotNull;
Expand Down Expand Up @@ -51,14 +52,14 @@
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;

public class ITHighPrecisionTimestamp {
class ITHighPrecisionTimestamp {

public static final String TEST_HIGH_PRECISION_TIMESTAMP_TABLE_NAME =
"test_high_precision_timestamp";
private static final String TEST_HIGH_PRECISION_TIMESTAMP_TABLE_NAME =
generateTempTableName("test_high_precision_timestamp");
private static BigQuery bigquery;
private static final String DATASET = RemoteBigQueryHelper.generateDatasetName();
private static TableId defaultTableId;
public static final long TIMESTAMP_PICOSECOND_PRECISION = 12L;
private static final long TIMESTAMP_PICOSECOND_PRECISION = 12L;
private static final Field TIMESTAMP_HIGH_PRECISION_FIELD_SCHEMA =
Field.newBuilder("timestampHighPrecisionField", StandardSQLTypeName.TIMESTAMP)
.setTimestampPrecision(TIMESTAMP_PICOSECOND_PRECISION)
Expand All @@ -69,8 +70,12 @@ public class ITHighPrecisionTimestamp {
private static final String TIMESTAMP2 = "1970-01-01T12:34:56.123456789123Z";
private static final String TIMESTAMP3 = "2000-01-01T12:34:56.123456789123Z";

private static String generateTempTableName(String prefix) {
return String.format("%s_%s", prefix, UUID.randomUUID().toString().substring(0, 8));
}

@BeforeAll
public static void beforeClass() {
static void beforeClass() {
BigQueryOptions.Builder builder =
BigQueryOptions.newBuilder()
.setDataFormatOptions(
Expand Down Expand Up @@ -111,21 +116,15 @@ public static void beforeClass() {
}

@AfterAll
public static void afterClass() {
static void afterClass() {
if (bigquery != null) {
bigquery.delete(defaultTableId);
RemoteBigQueryHelper.forceDelete(bigquery, DATASET);
}
}

private static String generateTempTableName() {
return String.format(
"insert_temp_%s%s",
UUID.randomUUID().toString().substring(0, 6), TEST_HIGH_PRECISION_TIMESTAMP_TABLE_NAME);
}

@Test
public void query_highPrecisionTimestamp() throws InterruptedException {
void query_highPrecisionTimestamp() throws InterruptedException {
String sql =
String.format("SELECT timestampHighPrecisionField FROM %s;", defaultTableId.getTable());
QueryJobConfiguration queryJobConfiguration =
Expand All @@ -141,16 +140,14 @@ public void query_highPrecisionTimestamp() throws InterruptedException {
.map(x -> (String) x.get(0).getValue())
.collect(Collectors.toList());
assertEquals(expected.length, timestamps.size());
for (int i = 0; i < timestamps.size(); i++) {
assertEquals(expected[i], timestamps.get(i));
}
assertThat(timestamps).containsAtLeastElementsIn(expected);
}

@Test
public void insert_highPrecisionTimestamp_ISOValidFormat() {
void insert_highPrecisionTimestamp_ISOValidFormat() {
StandardTableDefinition tableDefinition =
StandardTableDefinition.newBuilder().setSchema(TABLE_SCHEMA).build();
String tempTableName = generateTempTableName();
String tempTableName = generateTempTableName("insert_temp");
TableId tableId = TableId.of(DATASET, tempTableName);
Table createdTable = bigquery.create(TableInfo.of(tableId, tableDefinition));
assertNotNull(createdTable);
Expand All @@ -166,10 +163,10 @@ public void insert_highPrecisionTimestamp_ISOValidFormat() {
}

@Test
public void insert_highPrecisionTimestamp_invalidFormats() {
void insert_highPrecisionTimestamp_invalidFormats() {
StandardTableDefinition tableDefinition =
StandardTableDefinition.newBuilder().setSchema(TABLE_SCHEMA).build();
String tempTable = generateTempTableName();
String tempTable = generateTempTableName("insert_temp");
TableId tableId = TableId.of(DATASET, tempTable);
Table createdTable = bigquery.create(TableInfo.of(tableId, tableDefinition));
assertNotNull(createdTable);
Expand Down Expand Up @@ -207,7 +204,7 @@ public void insert_highPrecisionTimestamp_invalidFormats() {
}

@Test
public void queryNamedParameter_highPrecisionTimestamp() throws InterruptedException {
void queryNamedParameter_highPrecisionTimestamp() throws InterruptedException {
String query =
String.format(
"SELECT * FROM %s.%s WHERE timestampHighPrecisionField >= CAST(@timestampParam AS TIMESTAMP(12))",
Expand All @@ -219,6 +216,7 @@ public void queryNamedParameter_highPrecisionTimestamp() throws InterruptedExcep
.setUseLegacySql(false)
.addNamedParameter(
"timestampParam",
// For named parameters, java-bigquery does not expect the 'T'
QueryParameterValue.timestamp("2000-01-01 12:34:56.123456789123Z"))
.build();

Expand All @@ -230,13 +228,38 @@ public void queryNamedParameter_highPrecisionTimestamp() throws InterruptedExcep
.map(x -> (String) x.get(0).getValue())
.collect(Collectors.toList());
assertEquals(expected.length, timestamps.size());
for (int i = 0; i < timestamps.size(); i++) {
assertEquals(expected[i], timestamps.get(i));
}
assertThat(timestamps).containsAtLeastElementsIn(expected);
}

@Test
void queryPositionalParameter_highPrecisionTimestamp() throws InterruptedException {
String query =
String.format(
"SELECT * FROM %s.%s WHERE timestampHighPrecisionField >= CAST(? AS TIMESTAMP(12))",
DATASET, defaultTableId.getTable());

QueryJobConfiguration queryConfig =
QueryJobConfiguration.newBuilder(query)
.setDefaultDataset(DATASET)
.setUseLegacySql(false)
.addPositionalParameter(
// For positional parameters, java-bigquery does not expect the 'T'
QueryParameterValue.timestamp("2000-01-01 12:34:56.123456789123Z"))
.build();

TableResult result = bigquery.query(queryConfig);
assertNotNull(result);
String[] expected = new String[] {TIMESTAMP1, TIMESTAMP3};
List<String> timestamps =
StreamSupport.stream(result.getValues().spliterator(), false)
.map(x -> (String) x.get(0).getValue())
.collect(Collectors.toList());
assertEquals(expected.length, timestamps.size());
assertThat(timestamps).containsAtLeastElementsIn(expected);
}

@Test
public void queryNamedParameter_highPrecisionTimestamp_microsLong() throws InterruptedException {
void queryNamedParameter_highPrecisionTimestamp_microsLong() throws InterruptedException {
String query =
String.format(
"SELECT * FROM %s.%s WHERE timestampHighPrecisionField >= CAST(@timestampParam AS TIMESTAMP(12))",
Expand All @@ -263,14 +286,11 @@ public void queryNamedParameter_highPrecisionTimestamp_microsLong() throws Inter
.map(x -> (String) x.get(0).getValue())
.collect(Collectors.toList());
assertEquals(expected.length, timestamps.size());
for (int i = 0; i < timestamps.size(); i++) {
assertEquals(expected[i], timestamps.get(i));
}
assertThat(timestamps).containsAtLeastElementsIn(expected);
}

@Test
public void queryNamedParameter_highPrecisionTimestamp_microsISOString()
throws InterruptedException {
void queryNamedParameter_highPrecisionTimestamp_microsISOString() throws InterruptedException {
String query =
String.format(
"SELECT * FROM %s.%s WHERE timestampHighPrecisionField >= CAST(@timestampParam AS TIMESTAMP(12))",
Expand All @@ -281,6 +301,7 @@ public void queryNamedParameter_highPrecisionTimestamp_microsISOString()
.setDefaultDataset(DATASET)
.setUseLegacySql(false)
.addNamedParameter(
// For named parameters, java-bigquery does not expect the 'T'
"timestampParam", QueryParameterValue.timestamp("2000-01-01 12:34:56.123456Z"))
.build();

Expand All @@ -292,13 +313,11 @@ public void queryNamedParameter_highPrecisionTimestamp_microsISOString()
.collect(Collectors.toList());
String[] expected = new String[] {TIMESTAMP1, TIMESTAMP3};
assertEquals(expected.length, timestamps.size());
for (int i = 0; i < timestamps.size(); i++) {
assertEquals(expected[i], timestamps.get(i));
}
assertThat(timestamps).containsAtLeastElementsIn(expected);
}

@Test
public void queryNamedParameter_highPrecisionTimestamp_noExplicitCastInQuery_fails() {
void queryNamedParameter_highPrecisionTimestamp_noExplicitCastInQuery_fails() {
String query =
String.format(
"SELECT * FROM %s.%s WHERE timestampHighPrecisionField >= @timestampParam",
Expand All @@ -309,6 +328,7 @@ public void queryNamedParameter_highPrecisionTimestamp_noExplicitCastInQuery_fai
.setDefaultDataset(DATASET)
.setUseLegacySql(false)
.addNamedParameter(
// For named parameters, java-bigquery does not expect the 'T'
"timestampParam", QueryParameterValue.timestamp("2000-01-01 12:34:56.123456789123"))
.build();

Expand Down
Loading