Skip to content

feat: add read attempt and operation timeout to ExportJob settings #4533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mutianf wants to merge 2 commits into
base: main
Choose a base branch
from
+42 −1
Open

feat: add read attempt and operation timeout to ExportJob settings #4533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5473636
feat: add read attempt and operation timeout to ExportJob settings
mutianf Feb 15, 2026
f73300b
use nested value provider
mutianf Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...se/src/main/java/com/google/cloud/bigtable/hbase/wrappers/veneer/DataClientVeneerApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import com.google.cloud.bigtable.data.v2.models.Row;
import com.google.cloud.bigtable.data.v2.models.RowMutation;
import com.google.cloud.bigtable.hbase.adapters.Adapters;
import com.google.cloud.bigtable.hbase.util.Logger;
import com.google.cloud.bigtable.hbase.wrappers.BulkMutationWrapper;
import com.google.cloud.bigtable.hbase.wrappers.BulkReadWrapper;
import com.google.cloud.bigtable.hbase.wrappers.DataClientWrapper;
Expand All @@ -59,11 +60,14 @@
import org.apache.hadoop.hbase.client.AbstractClientScanner;
import org.apache.hadoop.hbase.client.Result;
import org.apache.hadoop.hbase.client.ResultScanner;
import org.threeten.bp.Duration;

/** For internal use only - public for technical reasons. */
@InternalApi("For internal usage only")
public class DataClientVeneerApi implements DataClientWrapper {

private final Logger LOG = new Logger(DataClientVeneerApi.class);

private static final RowResultAdapter RESULT_ADAPTER = new RowResultAdapter();

private final BigtableDataClient delegate;
Expand Down Expand Up @@ -203,7 +207,9 @@ private GrpcCallContext createScanCallContext() {
callSettings.getOperationTimeout().get().toMillis(), TimeUnit.MILLISECONDS)));
}
if (callSettings.getAttemptTimeout().isPresent()) {
ctx = ctx.withTimeout(callSettings.getAttemptTimeout().get());
Duration attemptTimeout = callSettings.getAttemptTimeout().get();
LOG.info("effective attempt timeout for scan is %s", attemptTimeout);
ctx = ctx.withTimeout(attemptTimeout);
}

return ctx;
Expand Down
23 changes: 23 additions & 0 deletions ...rent/bigtable-beam-import/src/main/java/com/google/cloud/bigtable/beam/TemplateUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,29 @@ public static CloudBigtableScanConfiguration buildExportConfig(ExportOptions opt
options.getBigtableStopRow(),
options.getBigtableMaxVersions(),
options.getBigtableFilter()));
if (options.getBigtableReadRpcTimeoutMs() != null) {
ValueProvider.NestedValueProvider.of(
options.getBigtableReadRpcTimeoutMs(),
(Integer timeout) -> {
if (timeout != null) {
configBuilder.withConfiguration(
BigtableOptionsFactory.BIGTABLE_READ_RPC_TIMEOUT_MS_KEY, String.valueOf(timeout));
}
return null;
});
}
if (options.getBigtableReadRpcAttemptTimeoutMs() != null) {
ValueProvider.NestedValueProvider.of(
options.getBigtableReadRpcAttemptTimeoutMs(),
(Integer timeout) -> {
if (timeout != null) {
configBuilder.withConfiguration(
BigtableOptionsFactory.BIGTABLE_READ_RPC_ATTEMPT_TIMEOUT_MS_KEY,
String.valueOf(timeout));
}
return null;
});
}
return configBuilder.build();
}
}
12 changes: 12 additions & 0 deletions ...ble-beam-import/src/main/java/com/google/cloud/bigtable/beam/sequencefiles/ExportJob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,18 @@ public interface ExportOptions extends GcpOptions, GcsOptions {

@SuppressWarnings("unused")
void setRetryIdleTimeout(boolean retryIdleTimeout);

@Description("Read RPC timeout in milliseconds.")
ValueProvider<Integer> getBigtableReadRpcTimeoutMs();

@SuppressWarnings("unused")
void setBigtableReadRpcTimeoutMs(ValueProvider<Integer> readRpcTimeoutMs);

@Description("Read RPC attempt timeout in milliseconds.")
ValueProvider<Integer> getBigtableReadRpcAttemptTimeoutMs();

@SuppressWarnings("unused")
void setBigtableReadRpcAttemptTimeoutMs(ValueProvider<Integer> readRpcAttemptTimeoutMs);
}

public static void main(String[] args) {
Expand Down