Fix Firestore SDK not limiting results when given limit(0)
#2464
+16
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opening this PR to sense check if this can be worked on to get merged. This PR fixes #2461 where the Firestore SDK doesn't seem to apply the limit clause when
limit(0)is given.Impact
The change should allow the Firestore SDK to handle
limit(0)properly, i.e., returning an empty array as expected.Testing
Unit test added. But I'm not familiar with the codebase so I'm not sure if that alone is sufficient.
Additional Information
Checklist
Fixes #2461 🦕