Skip to content

chore: Gen AI SDK client - update types in Prompt Optimizer #5527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 11, 2025
Merged

chore: Gen AI SDK client - update types in Prompt Optimizer #5527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/unit/vertexai/genai/replays/test_prompt_optimizer_optimize_job_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ def test_optimize(client):
method="vapo",
config=config,
)
assert isinstance(job, types.CustomJob)
assert job.state == types.JobState.JOB_STATE_SUCCEEDED


Expand Down
36 changes: 16 additions & 20 deletions vertexai/_genai/prompt_optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,16 +618,14 @@ def optimize(
}
args = ["--%s=%s" % (k, v) for k, v in container_args.items()]
worker_pool_specs = [
{
"replica_count": 1,
"container_spec": {
"image_uri": container_uri,
"args": args,
},
"machine_spec": {
"machine_type": "n1-standard-4",
},
}
types.WorkerPoolSpec(
replica_count=1,
machine_spec=types.MachineSpec(machine_type="n1-standard-4"),
container_spec=types.ContainerSpec(
image_uri=container_uri,
args=args,
),
)
]

service_account = _prompt_optimizer_utils._get_service_account(config)
Expand Down Expand Up @@ -879,16 +877,14 @@ async def optimize(
}
args = ["--%s=%s" % (k, v) for k, v in container_args.items()]
worker_pool_specs = [
{
"replica_count": 1,
"container_spec": {
"image_uri": container_uri,
"args": args,
},
"machine_spec": {
"machine_type": "n1-standard-4",
},
}
types.WorkerPoolSpec(
replica_count=1,
machine_spec=types.MachineSpec(machine_type="n1-standard-4"),
container_spec=types.ContainerSpec(
image_uri=container_uri,
args=args,
),
)
]

service_account = _prompt_optimizer_utils._get_service_account(config)
Expand Down
Loading