Skip to content

Conversation

@daniel-sanche
Copy link
Contributor

fix a couple typing issues that were causing recent versions of mypy to fail:

  • exceptions.py: error_info variable was reused for a list, and for an optional dict type. Broke the usages into separate variables
  • grpc_helpers_async: added Generic to _WrappedCall
  • retry_unary: removed _P arguments from target type annotation. We expect target to be a functools.partial, and have no arguments

Fixes #682

@daniel-sanche daniel-sanche requested review from a team as code owners December 16, 2024 19:52
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Dec 16, 2024
@daniel-sanche daniel-sanche marked this pull request as draft December 16, 2024 23:05
@daniel-sanche daniel-sanche marked this pull request as ready for review December 17, 2024 17:59
@parthea parthea enabled auto-merge (squash) January 22, 2025 21:27
@parthea parthea merged commit fb1c3a9 into main Jan 22, 2025
42 checks passed
@parthea parthea deleted the update_mypy branch January 22, 2025 21:27
@parthea
Copy link
Collaborator

parthea commented Jan 22, 2025

Thanks @daniel-sanche !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mypy presubmit fails at HEAD with mypy 1.11+

2 participants