tests: refactor lint nox sessions #874
Closed
+11
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "types-dataclasses", | ||
| "types-mock; python_version=='3.7'", | ||
| ) | ||
| session.run("mypy", "google", "tests") |
Contributor
There was a problem hiding this comment.
I do think there's value in being able to run mypy on its own sometimes.
It could be annoying to have to fix all other style issues, before even seeing if the types are valid
Collaborator
Author
There was a problem hiding this comment.
Ack. I'll keep mypy as a separate presubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed as part of b/463296248. Instead of having 2 different presubmits that run lint and mypy checks, we now have these 2 patterns tested under a single nox session. This follows the pattern that we have in google-cloud-python where there is a single lint nox session.
The
pytypenox session was not running as a presubmit so I've removed it.pytypehas been deprecated as per this note.