Skip to content

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented Jun 30, 2025

  • Correct the table size to match actual percentiles.
  • Only do sum() on numeric columns.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal issue b/420984164#comment13 🦕

* Correct the table size to match actual percentiles.
* Only do sum() on numeric columns.
@tswast tswast requested review from a team as code owners June 30, 2025 17:13
@tswast tswast requested a review from jialuoo June 30, 2025 17:13
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jun 30, 2025
@tswast tswast assigned jialuoo and unassigned drylks-work Jun 30, 2025
@tswast tswast merged commit bb98178 into main Jun 30, 2025
25 checks passed
@tswast tswast deleted the b420984164-benchmark-fixes branch June 30, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants