chore: use bigframes.pandas._read_gbq_colab() in benchmarks
#1939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
I have refactored the `read_gbq_colab` benchmarks to call `bigframes.pandas`. I updated the benchmarks in `tests/benchmark/read_gbq_colab` to call `bigframes.pandas._read_gbq_colab(...)` instead of `session._read_gbq_colab(...)`. Since the `session` object is no longer needed in these benchmarks, I also removed that dependency.
tswast
force-pushed
the
update-read-gbq-colab-benchmarks
branch
from
4421cbf to
76ebabe
Compare
tswast
commented
Jul 25, 2025
| session, | ||
| suffix, | ||
| ) = utils.get_configuration(include_table_id=True) | ||
| ) = utils.get_configuration(include_table_id=True, include_session=False) |
Collaborator
Author
There was a problem hiding this comment.
This parameter doesn't actually exist. Might be nice to have a start_session=False argument, though.
Collaborator
Author
|
Not worth resolving the conflicts. I'll try with Jules again in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pandas`.
I updated the benchmarks in
tests/benchmark/read_gbq_colabto callbigframes.pandas._read_gbq_colab(...)instead ofsession._read_gbq_colab(...).Since the
sessionobject is no longer needed in these benchmarks, I also removed that dependency.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕