Skip to content

chore: refactor get_configuration to use a dataclass #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tswast merged 3 commits into from
Jul 25, 2025
Merged

chore: refactor get_configuration to use a dataclass #1940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fc7824
Refactor get_configuration to use a dataclass
google-labs-jules[bot] Jul 25, 2025
826a70c
I will refactor `get_configuration` to use a dataclass.
google-labs-jules[bot] Jul 25, 2025
5ac2512
I will refactor `get_configuration` to use a dataclass.
google-labs-jules[bot] Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions tests/benchmark/db_benchmark/groupby/q1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,15 @@
import bigframes_vendored.db_benchmark.groupby_queries as vendored_dbbenchmark_groupby_queries

if __name__ == "__main__":
(
project_id,
dataset_id,
table_id,
session,
suffix,
) = utils.get_configuration(include_table_id=True)
config = utils.get_configuration(include_table_id=True)
current_path = pathlib.Path(__file__).absolute()

utils.get_execution_time(
vendored_dbbenchmark_groupby_queries.q1,
current_path,
suffix,
project_id,
dataset_id,
table_id,
session,
config.benchmark_suffix,
config.project_id,
config.dataset_id,
config.table_id,
config.session,
)
18 changes: 6 additions & 12 deletions tests/benchmark/db_benchmark/groupby/q10.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,15 @@
import bigframes_vendored.db_benchmark.groupby_queries as vendored_dbbenchmark_groupby_queries

if __name__ == "__main__":
(
project_id,
dataset_id,
table_id,
session,
suffix,
) = utils.get_configuration(include_table_id=True)
config = utils.get_configuration(include_table_id=True)
current_path = pathlib.Path(__file__).absolute()

utils.get_execution_time(
vendored_dbbenchmark_groupby_queries.q10,
current_path,
suffix,
project_id,
dataset_id,
table_id,
session,
config.benchmark_suffix,
config.project_id,
config.dataset_id,
config.table_id,
config.session,
)
18 changes: 6 additions & 12 deletions tests/benchmark/db_benchmark/groupby/q2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,15 @@
import bigframes_vendored.db_benchmark.groupby_queries as vendored_dbbenchmark_groupby_queries

if __name__ == "__main__":
(
project_id,
dataset_id,
table_id,
session,
suffix,
) = utils.get_configuration(include_table_id=True)
config = utils.get_configuration(include_table_id=True)
current_path = pathlib.Path(__file__).absolute()

utils.get_execution_time(
vendored_dbbenchmark_groupby_queries.q2,
current_path,
suffix,
project_id,
dataset_id,
table_id,
session,
config.benchmark_suffix,
config.project_id,
config.dataset_id,
config.table_id,
config.session,
)
18 changes: 6 additions & 12 deletions tests/benchmark/db_benchmark/groupby/q3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,15 @@
import bigframes_vendored.db_benchmark.groupby_queries as vendored_dbbenchmark_groupby_queries

if __name__ == "__main__":
(
project_id,
dataset_id,
table_id,
session,
suffix,
) = utils.get_configuration(include_table_id=True)
config = utils.get_configuration(include_table_id=True)
current_path = pathlib.Path(__file__).absolute()

utils.get_execution_time(
vendored_dbbenchmark_groupby_queries.q3,
current_path,
suffix,
project_id,
dataset_id,
table_id,
session,
config.benchmark_suffix,
config.project_id,
config.dataset_id,
config.table_id,
config.session,
)
18 changes: 6 additions & 12 deletions tests/benchmark/db_benchmark/groupby/q4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,15 @@
import bigframes_vendored.db_benchmark.groupby_queries as vendored_dbbenchmark_groupby_queries

if __name__ == "__main__":
(
project_id,
dataset_id,
table_id,
session,
suffix,
) = utils.get_configuration(include_table_id=True)
config = utils.get_configuration(include_table_id=True)
current_path = pathlib.Path(__file__).absolute()

utils.get_execution_time(
vendored_dbbenchmark_groupby_queries.q4,
current_path,
suffix,
project_id,
dataset_id,
table_id,
session,
config.benchmark_suffix,
config.project_id,
config.dataset_id,
config.table_id,
config.session,
)
18 changes: 6 additions & 12 deletions tests/benchmark/db_benchmark/groupby/q5.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,15 @@
import bigframes_vendored.db_benchmark.groupby_queries as vendored_dbbenchmark_groupby_queries

if __name__ == "__main__":
(
project_id,
dataset_id,
table_id,
session,
suffix,
) = utils.get_configuration(include_table_id=True)
config = utils.get_configuration(include_table_id=True)
current_path = pathlib.Path(__file__).absolute()

utils.get_execution_time(
vendored_dbbenchmark_groupby_queries.q5,
current_path,
suffix,
project_id,
dataset_id,
table_id,
session,
config.benchmark_suffix,
config.project_id,
config.dataset_id,
config.table_id,
config.session,
)
18 changes: 6 additions & 12 deletions tests/benchmark/db_benchmark/groupby/q6.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,15 @@
import bigframes_vendored.db_benchmark.groupby_queries as vendored_dbbenchmark_groupby_queries

if __name__ == "__main__":
(
project_id,
dataset_id,
table_id,
session,
suffix,
) = utils.get_configuration(include_table_id=True)
config = utils.get_configuration(include_table_id=True)
current_path = pathlib.Path(__file__).absolute()

utils.get_execution_time(
vendored_dbbenchmark_groupby_queries.q6,
current_path,
suffix,
project_id,
dataset_id,
table_id,
session,
config.benchmark_suffix,
config.project_id,
config.dataset_id,
config.table_id,
config.session,
)
18 changes: 6 additions & 12 deletions tests/benchmark/db_benchmark/groupby/q7.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,15 @@
import bigframes_vendored.db_benchmark.groupby_queries as vendored_dbbenchmark_groupby_queries

if __name__ == "__main__":
(
project_id,
dataset_id,
table_id,
session,
suffix,
) = utils.get_configuration(include_table_id=True)
config = utils.get_configuration(include_table_id=True)
current_path = pathlib.Path(__file__).absolute()

utils.get_execution_time(
vendored_dbbenchmark_groupby_queries.q7,
current_path,
suffix,
project_id,
dataset_id,
table_id,
session,
config.benchmark_suffix,
config.project_id,
config.dataset_id,
config.table_id,
config.session,
)
18 changes: 6 additions & 12 deletions tests/benchmark/db_benchmark/groupby/q8.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,15 @@
import bigframes_vendored.db_benchmark.groupby_queries as vendored_dbbenchmark_groupby_queries

if __name__ == "__main__":
(
project_id,
dataset_id,
table_id,
session,
suffix,
) = utils.get_configuration(include_table_id=True)
config = utils.get_configuration(include_table_id=True)
current_path = pathlib.Path(__file__).absolute()

utils.get_execution_time(
vendored_dbbenchmark_groupby_queries.q8,
current_path,
suffix,
project_id,
dataset_id,
table_id,
session,
config.benchmark_suffix,
config.project_id,
config.dataset_id,
config.table_id,
config.session,
)
18 changes: 6 additions & 12 deletions tests/benchmark/db_benchmark/join/q1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,16 @@
import bigframes_vendored.db_benchmark.join_queries as vendored_dbbenchmark_join_queries

if __name__ == "__main__":
(
project_id,
dataset_id,
table_id,
session,
suffix,
) = utils.get_configuration(include_table_id=True)
config = utils.get_configuration(include_table_id=True)

current_path = pathlib.Path(__file__).absolute()

utils.get_execution_time(
vendored_dbbenchmark_join_queries.q1,
current_path,
suffix,
project_id,
dataset_id,
table_id,
session,
config.benchmark_suffix,
config.project_id,
config.dataset_id,
config.table_id,
config.session,
)
18 changes: 6 additions & 12 deletions tests/benchmark/db_benchmark/join/q2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,16 @@
import bigframes_vendored.db_benchmark.join_queries as vendored_dbbenchmark_join_queries

if __name__ == "__main__":
(
project_id,
dataset_id,
table_id,
session,
suffix,
) = utils.get_configuration(include_table_id=True)
config = utils.get_configuration(include_table_id=True)

current_path = pathlib.Path(__file__).absolute()

utils.get_execution_time(
vendored_dbbenchmark_join_queries.q2,
current_path,
suffix,
project_id,
dataset_id,
table_id,
session,
config.benchmark_suffix,
config.project_id,
config.dataset_id,
config.table_id,
config.session,
)
18 changes: 6 additions & 12 deletions tests/benchmark/db_benchmark/join/q3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,16 @@
import bigframes_vendored.db_benchmark.join_queries as vendored_dbbenchmark_join_queries

if __name__ == "__main__":
(
project_id,
dataset_id,
table_id,
session,
suffix,
) = utils.get_configuration(include_table_id=True)
config = utils.get_configuration(include_table_id=True)

current_path = pathlib.Path(__file__).absolute()

utils.get_execution_time(
vendored_dbbenchmark_join_queries.q3,
current_path,
suffix,
project_id,
dataset_id,
table_id,
session,
config.benchmark_suffix,
config.project_id,
config.dataset_id,
config.table_id,
config.session,
)
18 changes: 6 additions & 12 deletions tests/benchmark/db_benchmark/join/q4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,16 @@
import bigframes_vendored.db_benchmark.join_queries as vendored_dbbenchmark_join_queries

if __name__ == "__main__":
(
project_id,
dataset_id,
table_id,
session,
suffix,
) = utils.get_configuration(include_table_id=True)
config = utils.get_configuration(include_table_id=True)

current_path = pathlib.Path(__file__).absolute()

utils.get_execution_time(
vendored_dbbenchmark_join_queries.q4,
current_path,
suffix,
project_id,
dataset_id,
table_id,
session,
config.benchmark_suffix,
config.project_id,
config.dataset_id,
config.table_id,
config.session,
)
18 changes: 6 additions & 12 deletions tests/benchmark/db_benchmark/join/q5.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,16 @@
import bigframes_vendored.db_benchmark.join_queries as vendored_dbbenchmark_join_queries

if __name__ == "__main__":
(
project_id,
dataset_id,
table_id,
session,
suffix,
) = utils.get_configuration(include_table_id=True)
config = utils.get_configuration(include_table_id=True)

current_path = pathlib.Path(__file__).absolute()

utils.get_execution_time(
vendored_dbbenchmark_join_queries.q5,
current_path,
suffix,
project_id,
dataset_id,
table_id,
session,
config.benchmark_suffix,
config.project_id,
config.dataset_id,
config.table_id,
config.session,
)
Loading