Skip to content

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented Jul 30, 2025

The pyarrow.orc module is an optional extension that isn't available internally.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

The pyarrow.orc module is an optional extension that isn't available internally.
@tswast tswast requested review from a team as code owners July 30, 2025 16:09
@tswast tswast requested a review from chelsea-lin July 30, 2025 16:09
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jul 30, 2025
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am wondering how the test passes before this change without checking the package?

@tswast
Copy link
Collaborator Author

tswast commented Jul 31, 2025

LGTM. I am wondering how the test passes before this change without checking the package?

Before my cl/788930779, we were skipping this test internally. I think it's pretty rare to get a custom pyarrow that has some C++ modules excluded "in the wild", so I'm not too surprised that we didn't see this before.

@tswast tswast merged commit 2f524e6 into main Jul 31, 2025
18 of 25 checks passed
@tswast tswast deleted the tswast-patch-1 branch July 31, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants