Skip to content

test: temp disable claude related test for presubmit #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shuoweil merged 4 commits into from
Aug 5, 2025
Merged

test: temp disable claude related test for presubmit #1962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70ad274
test: temp disable claude related test for presubmit
shuoweil Aug 5, 2025
9917f9f
test: disable test_df_ffill temporarily
shuoweil Aug 4, 2025
83eef30
add the reason for why it disable the test
shuoweil Aug 5, 2025
b943fd9
comment another test
shuoweil Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/system/small/ml/test_llm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ def __eq__(self, other):
return self.equals(other)


@pytest.mark.skip("b/436340035 test failed")
@pytest.mark.parametrize(
(
"model_class",
Expand Down Expand Up @@ -393,6 +394,7 @@ def test_text_generator_retry_success(
)


@pytest.mark.skip("b/436340035 test failed")
@pytest.mark.parametrize(
(
"model_class",
Expand Down Expand Up @@ -509,6 +511,7 @@ def test_text_generator_retry_no_progress(session, model_class, options, bq_conn
)


@pytest.mark.skip("b/436340035 test failed")
def test_text_embedding_generator_retry_success(session, bq_connection):
# Requests.
df0 = EqCmpAllDataFrame(
Expand Down Expand Up @@ -790,13 +793,14 @@ def test_gemini_preview_model_warnings(model_name):
llm.GeminiTextGenerator(model_name=model_name)


# b/436340035 temp disable the test to unblock presumbit
@pytest.mark.parametrize(
"model_class",
[
llm.TextEmbeddingGenerator,
llm.MultimodalEmbeddingGenerator,
llm.GeminiTextGenerator,
llm.Claude3TextGenerator,
# llm.Claude3TextGenerator,
],
)
def test_text_embedding_generator_no_default_model_warning(model_class):
Expand Down
1 change: 1 addition & 0 deletions tests/unit/test_dataframe_polars.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1198,6 +1198,7 @@ def test_df_fillna(scalars_dfs, col, fill_value):
pd.testing.assert_frame_equal(bf_result, pd_result, check_dtype=False)


@pytest.mark.skip("b/436316698 unit test failed for python 3.12")
def test_df_ffill(scalars_dfs):
scalars_df, scalars_pandas_df = scalars_dfs
bf_result = scalars_df[["int64_col", "float64_col"]].ffill(limit=1).to_pandas()
Expand Down
Loading