Skip to content

refactor: add agg_ops.MeanOp for sqlglot compiler #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chelsea-lin merged 1 commit into from
Sep 24, 2025
Merged

refactor: add agg_ops.MeanOp for sqlglot compiler #2096

chelsea-lin merged 1 commit into from
Sep 24, 2025

Conversation

@chelsea-lin
Copy link
Contributor

@chelsea-lin chelsea-lin commented Sep 17, 2025 •
edited
Loading

Fixes internal issue 445774480🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 17, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_aggmean branch 2 times, most recently from 1ff716d to b31c667 Compare September 18, 2025 00:16
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Sep 18, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_aggmean branch from ab29b75 to 884d488 Compare September 18, 2025 00:50
Base automatically changed from main_chelsealin_agg to main September 18, 2025 21:34
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_aggmean branch 3 times, most recently from 940aecb to b17effb Compare September 18, 2025 21:47
@chelsea-lin chelsea-lin marked this pull request as ready for review September 18, 2025 21:47
@chelsea-lin chelsea-lin requested review from a team as code owners September 18, 2025 21:47
@chelsea-lin chelsea-lin requested a review from tswast September 18, 2025 21:47
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_aggmean branch from b8a9293 to b0f14bd Compare September 23, 2025 21:19
@tswast
Copy link
Collaborator

tswast commented Sep 24, 2025

e2e failures:

FAILED tests/system/large/blob/test_function.py::test_blob_image_normalize_to_series
FAILED tests/system/large/blob/test_function.py::test_blob_exif - Failed: Tim...
FAILED tests/system/large/blob/test_function.py::test_blob_pdf_extract[False]
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_series_apply
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_with_connection[bq_connection_name]
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_series_apply_args
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_df_apply_axis_1
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_df_where_mask
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_array_output
FAILED tests/system/large/blob/test_function.py::test_blob_image_resize_to_series
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_dataframe_map_array_output
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_df_apply_axis_1_series_args
FAILED tests/system/large/blob/test_function.py::test_blob_image_normalize_to_folder
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_series_apply_array_output
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_with_connection[bq_connection]
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_df_where_mask_series
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_df_apply_axis_1_complex[all-kinds-of-column-names]
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_dataframe_apply_axis_1
FAILED tests/system/large/blob/test_function.py::test_blob_image_blur_to_folder
FAILED tests/system/large/blob/test_function.py::test_blob_pdf_chunk[False]
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_series_combine
FAILED tests/system/large/blob/test_function.py::test_blob_pdf_extract[True]
FAILED tests/system/large/functions/test_managed_function.py::test_managed_function_series_combine_array_output
= 23 failed, 371 passed, 10 skipped, 6 xfailed, 6 xpassed, 248 warnings in 3654.83s (1:00:54) =

These appear unrelated to this PR.

@chelsea-lin chelsea-lin merged commit caa824a into main Sep 24, 2025
24 of 25 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin_aggmean branch September 24, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

Assignees

@ivansmf ivansmf

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chelsea-lin @tswast @ivansmf