refactor: add agg_ops.MedianOp compiler to sqlglot #2108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
Comment on lines
96
to
104
| excluded_cols=[ | ||
| "bytes_col", | ||
| "date_col", | ||
| "datetime_col", | ||
| "time_col", | ||
| "timestamp_col", | ||
| "string_col", | ||
| ], | ||
| ).node |
Contributor
There was a problem hiding this comment.
Can we modify the MedianOp definition itself to exclude these then?
Contributor
Author
There was a problem hiding this comment.
Updated the codes so that the Ibis can allow the non-numeric dtypes for the MedianOp now.
Comment on lines
65
to
67
| # TODO(swast): Allow switching between exact and approximate median. | ||
| # For now, the best we can do is an approximate median when we're doing | ||
| # an aggregation, as PERCENTILE_CONT is only an analytic function. |
Contributor
There was a problem hiding this comment.
Exact and approximate median work a lot differently mechanically, so I probably wouldn't handle this far down in the stack, we would probably dispatch a different operator close to the API surface.
Contributor
Author
There was a problem hiding this comment.
Removed the comments. We are using the QuantileOp for the exact median now.
chelsea-lin
force-pushed
the
main_chelsealin_median
branch
from
714bcb3 to
1edee54
Compare
TrevorBergeron
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes internal issue 445774480 🦕