Skip to content

Conversation

@jialuoo
Copy link
Contributor

@jialuoo jialuoo commented Nov 3, 2025

Migrated the maximum_op and minimum_op operators to SQLGlot.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/447388852 🦕

Migrated the maximum_op and minimum_op operators to SQLGlot.
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 3, 2025
@jialuoo
Copy link
Contributor Author

jialuoo commented Nov 4, 2025

The sql from ibis:

SELECT
  CASE
    WHEN (
      `t0`.`float64_col` IS NULL
    ) OR (
      `t0`.`int64_col` < `t0`.`float64_col`
    )
    THEN `t0`.`float64_col`
    ELSE `t0`.`int64_col`
  END AS `int64_col`
FROM (
  SELECT
    `int64_col`,
    `float64_col`
  FROM `bigframes-dev.sqlglot_test.scalar_types`
) AS `t0`

@jialuoo jialuoo requested a review from chelsea-lin November 4, 2025 00:29
@jialuoo jialuoo marked this pull request as ready for review November 4, 2025 00:29
@jialuoo jialuoo requested review from a team as code owners November 4, 2025 00:29
@jialuoo jialuoo added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 4, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 4, 2025
@jialuoo jialuoo enabled auto-merge (squash) November 4, 2025 18:13
@jialuoo jialuoo merged commit bfbb2f0 into main Nov 4, 2025
24 of 25 checks passed
@jialuoo jialuoo deleted the feat/migrate-maximum-op branch November 4, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants