Skip to content

feat: Normalize project and location in connection IDs #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shuoweil wants to merge 2 commits into from
Closed

feat: Normalize project and location in connection IDs #2234

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be5a7db
feat: Normalize project and location in connection IDs
shuoweil Nov 5, 2025
33023c8
Merge branch 'main' into shuowei-check-connection-name
shuoweil Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/system/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,16 +72,16 @@ def _hash_digest_file(hasher, filepath):

@pytest.fixture(scope="session")
def normalize_connection_id():
"""Normalizes the connection ID by casefolding only the LOCATION component.
"""Normalizes the connection ID by casefolding the PROJECT and LOCATION components.

Connection format: PROJECT.LOCATION.CONNECTION_NAME
Only LOCATION is case-insensitive; PROJECT and CONNECTION_NAME must be lowercase.
PROJECT and LOCATION are case-insensitive; CONNECTION_NAME must be lowercase.
"""

def normalize(connection_id: str) -> str:
parts = connection_id.split(".")
if len(parts) == 3:
return f"{parts[0]}.{parts[1].casefold()}.{parts[2]}"
return f"{parts[0].casefold()}.{parts[1].casefold()}.{parts[2]}"
return connection_id # Return unchanged if invalid format

return normalize
Expand Down