Skip to content

chore: Migrate manhattan_distance_op operator to SQLGlot #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jialuoo merged 3 commits into from
Nov 13, 2025
Merged

chore: Migrate manhattan_distance_op operator to SQLGlot #2254

jialuoo merged 3 commits into from
Nov 13, 2025

Conversation

@jialuoo
Copy link
Contributor

@jialuoo jialuoo commented Nov 11, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/447388852 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 11, 2025
@jialuoo jialuoo requested a review from chelsea-lin November 12, 2025 18:54
@jialuoo jialuoo marked this pull request as ready for review November 12, 2025 18:55
@jialuoo jialuoo requested review from a team as code owners November 12, 2025 18:55
@chelsea-lin chelsea-lin added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 12, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 12, 2025
chelsea-lin
chelsea-lin requested changes Nov 12, 2025
View reviewed changes
@jialuoo jialuoo force-pushed the migrate-manhatton-dist branch from 55e75af to 8fa638f Compare November 13, 2025 01:36
@jialuoo jialuoo requested a review from chelsea-lin November 13, 2025 01:37
@jialuoo jialuoo enabled auto-merge (squash) November 13, 2025 20:03
@jialuoo jialuoo merged commit 3702f56 into main Nov 13, 2025
24 of 25 checks passed
@jialuoo jialuoo deleted the migrate-manhatton-dist branch November 13, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

Assignees

@chelsea-lin chelsea-lin

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jialuoo @chelsea-lin