-
Notifications
You must be signed in to change notification settings - Fork 5
feat: support python 3.14 #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Linchin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces compatibility and official support for Python 3.14. It updates the project's metadata to reflect this new support and ensures that the correct Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for Python 3.14 by updating setup.py. It adds a new grpcio dependency constraint for Python 3.14 and includes the Programming Language :: Python :: 3.14 classifier.
While the changes are functionally correct, I've suggested a small improvement to the dependency specifiers for grpcio to make them more explicit and maintainable by avoiding overlapping version conditions.
Additionally, to fully complete Python 3.14 support, you might need to:
- Add Python 3.14 to your CI test matrix to ensure everything works as expected.
- Add a
testing/constraints-3.14.txtfile, similar to the ones for other Python versions.
Overall, this is a good step towards supporting the next version of Python.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
samples-3.14 will not pass until GoogleCloudPlatform/python-docs-samples#13596 is merged. So for now we will mark this test as not required. |
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for Python 3.14 by updating the necessary configuration files, test definitions, and package metadata. The changes in .kokoro configs, setup.py, and the test matrices in noxfile.py are appropriate for supporting the new Python version. I have one suggestion in noxfile.py to reduce code duplication and improve maintainability. Additionally, a critical update seems to be missing in noxfile.py which I cannot comment on directly. The prerelease_deps session needs to be updated to run on Python 3.14. This involves updating the @nox.session decorator (line 426) and the conditional check for the cpp protobuf implementation (line 434) to include Python 3.14. Without these changes, the prerelease-deps-3.14 CI job will likely fail.
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620 <details><summary>bigquery-magics: 0.11.0</summary> ## [0.11.0](v0.10.3...v0.11.0) (2025-12-15) ### Features * support python 3.14 (#165) ([8ee73ec](8ee73ecf)) </details>
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕