Skip to content

Conversation

@Linchin
Copy link
Contributor

@Linchin Linchin commented Dec 15, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@Linchin Linchin requested review from a team as code owners December 15, 2025 19:52
@Linchin Linchin requested review from mrfaizal and shuoweil December 15, 2025 19:52
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Dec 15, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-magics API. label Dec 15, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @Linchin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces compatibility and official support for Python 3.14. It updates the project's metadata to reflect this new support and ensures that the correct grpcio dependency version is used when running on Python 3.14.

Highlights

  • Python 3.14 Support: The project now officially declares support for Python 3.14 by adding it to the classifiers in setup.py.
  • Dependency Update: A specific version of grpcio (>= 1.75.1, < 2.0.0) has been added as a dependency requirement for Python 3.14 environments.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Python 3.14 by updating setup.py. It adds a new grpcio dependency constraint for Python 3.14 and includes the Programming Language :: Python :: 3.14 classifier.

While the changes are functionally correct, I've suggested a small improvement to the dependency specifiers for grpcio to make them more explicit and maintainable by avoiding overlapping version conditions.

Additionally, to fully complete Python 3.14 support, you might need to:

  • Add Python 3.14 to your CI test matrix to ensure everything works as expected.
  • Add a testing/constraints-3.14.txt file, similar to the ones for other Python versions.

Overall, this is a good step towards supporting the next version of Python.

Linchin and others added 3 commits December 15, 2025 11:54
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Dec 15, 2025
shuoweil
shuoweil previously approved these changes Dec 15, 2025
@Linchin
Copy link
Contributor Author

Linchin commented Dec 15, 2025

samples-3.14 will not pass until GoogleCloudPlatform/python-docs-samples#13596 is merged. So for now we will mark this test as not required.

@Linchin Linchin added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 15, 2025
@Linchin
Copy link
Contributor Author

Linchin commented Dec 15, 2025

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Python 3.14 by updating the necessary configuration files, test definitions, and package metadata. The changes in .kokoro configs, setup.py, and the test matrices in noxfile.py are appropriate for supporting the new Python version. I have one suggestion in noxfile.py to reduce code duplication and improve maintainability. Additionally, a critical update seems to be missing in noxfile.py which I cannot comment on directly. The prerelease_deps session needs to be updated to run on Python 3.14. This involves updating the @nox.session decorator (line 426) and the conditional check for the cpp protobuf implementation (line 434) to include Python 3.14. Without these changes, the prerelease-deps-3.14 CI job will likely fail.

@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 15, 2025
@daniel-sanche daniel-sanche merged commit 8ee73ec into googleapis:main Dec 16, 2025
24 of 25 checks passed
daniel-sanche added a commit that referenced this pull request Dec 16, 2025
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.7.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620
<details><summary>bigquery-magics: 0.11.0</summary>

##
[0.11.0](v0.10.3...v0.11.0)
(2025-12-15)

### Features

* support python 3.14 (#165)
([8ee73ec](8ee73ecf))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-magics API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants