-
Notifications
You must be signed in to change notification settings - Fork 5
feat: support visualization of graph queries by adding the --graph argument. #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
6e79cd7
Implement graph visualization with the --graph argument.
ericfe-google a3b71a4
Skip graph server tests when spanner-graph-notebook is missing. Also,…
ericfe-google 86505aa
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] f5f2635
Merge branch 'main' into graph
ericfe-google cfc1bad
Fix lint errors and unit tests under nox.
ericfe-google bb05c5c
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] f37593d
Add spanner_graphs to owlbot. Also, fix typo in package name in error…
ericfe-google 258e894
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 8d18cf4
Fix owlbot entry
ericfe-google 92f6689
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 75386d5
Add spanner_graphs as optional dependency with minimum version 1.1.1.
ericfe-google 9f7f1c7
Change owlbot so spanner-graph-notebook is added to the config using …
ericfe-google 5f27b29
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] f05be37
Fix typo
ericfe-google f6058ed
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] b6b98c0
Fix dependent package name: spanner_graphs -> spanner-graph-notebook
ericfe-google bf82c60
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 858e72b
Add unit test coverage for the GraphServer object.
ericfe-google 942f7c1
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 6f9ddce
Add more unit tests for convert_graph_data() to boost code coverage.
ericfe-google b112cff
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 8f3100f
Add more tests.
ericfe-google cddb18c
Move get_ping() and post_ping() out of the GraphServer class, into th…
ericfe-google abd718a
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] b470c71
Add unit test for handle_post_query() in GraphServer.
ericfe-google f4266c3
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 02f0223
Fix lint, remove a line of dead code, mark test_post_query for skippi…
ericfe-google 6f06250
Remove more dead code in graph server, add test for --graph without s…
ericfe-google 19e53fb
Add unit tests for colab paths.
ericfe-google ec1e188
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 1df7454
Use pytest.raises() instead of try/except
ericfe-google 3885935
Add test coverage for the case where a graph query is run after the g…
ericfe-google ab47e37
Merge branch 'main' into graph
ericfe-google 4b27ebb
Add docstrings
ericfe-google 10c5d75
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 5257618
Move networkx and portpicker to extras under "spanner-graph-notebook".
ericfe-google 4356d39
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 0e04303
Finish making graph dependencies optional
ericfe-google fedca81
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 1824c7f
fix port
ericfe-google a706182
Convert graph server to singleton object.
ericfe-google e4767e7
reformat
ericfe-google c36506a
Fix handling of null json elements.
ericfe-google 3a06e69
reformat
ericfe-google cdbdb3f
Apply suggestions from code review
tswast 18a63e4
Merge branch 'main' into graph
tswast ccd7f30
Pin spanner-graph-notebook to exactly version 1.1.1, as subsequent ch…
ericfe-google c8a6520
Merge remote-tracking branch 'refs/remotes/origin/graph' into graph
ericfe-google File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do a warning if they asked for
--graphbut the results didn't support it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long-term, I view --graph as a temporary flag to avoid breaking the standard code path while the graph implementation is not stable yet. Eventually, I would like to see the flag go away, and the graph visualization just be automatic in response to running a graph query.
So, I don't think such a warning is warranted right now.