Skip to content

fix: handle non-list response_stream in HttpResponse.json property #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bardusco wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle non-list response_stream in HttpResponse.json property #1903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion google/genai/_api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,13 @@ async def __anext__(self) -> Any:

@property
def json(self) -> Any:
if not self.response_stream[0]: # Empty response
# Handle case where response_stream is not a list (e.g., aiohttp.ClientResponse)
# This can happen when the API returns an error and the response object
# is passed directly instead of being wrapped in a list.
# See: https://github.com/googleapis/python-genai/issues/1897
if not isinstance(self.response_stream, list):
return None
if not self.response_stream or not self.response_stream[0]: # Empty response
return ''
return self._load_json_from_response(self.response_stream[0])

Expand Down