Skip to content

Conversation

@dkhawk
Copy link
Contributor

@dkhawk dkhawk commented Jan 24, 2026

Description

Establishes a robust build verification pipeline and removes deprecated Rx samples.

Changes

  • Added scripts/verify_all.sh: A single script to verify all modules locally (Assemble + Test + Lint).
  • Enhanced CI: Updated .github/workflows/build.yml to run unit tests and lint checks.
  • Fixed Build/Tests:
    • Enabled mock-maker-inline for FireMarkers to fix testing final classes.
    • Fixed assertion mismatch in MarkersViewModelTest.
    • targeted correct build variants for snippets:app.

Verification

Run ./scripts/verify_all.sh to verify the entire project.

@dkhawk dkhawk requested a review from kikoso January 24, 2026 01:21
@@ -1,114 +1,157 @@
[versions]
# Project Configuration
androidGradlePlugin = "8.13.2"

Check warning

Code scanning / Android Lint

Obsolete Android Gradle Plugin Version Warning

A newer version of com.android.application than 8.13.2 is available: 9.0.0
@@ -1,114 +1,157 @@
[versions]
# Project Configuration
androidGradlePlugin = "8.13.2"

Check warning

Code scanning / Android Lint

Obsolete Android Gradle Plugin Version Warning

A newer version of com.android.library than 8.13.2 is available: 9.0.0
javaVersion = "17"

# Kotlin & Coroutines
kotlin = "2.2.0"

Check warning

Code scanning / Android Lint

Obsolete Gradle Dependency Warning

A newer version of org.jetbrains.kotlin:kotlin-stdlib than 2.2.0 is available: 2.3.0
javaVersion = "17"

# Kotlin & Coroutines
kotlin = "2.2.0"

Check warning

Code scanning / Android Lint

Obsolete Gradle Dependency Warning

A newer version of org.jetbrains.kotlin:kotlin-stdlib-jdk8 than 2.2.0 is available: 2.2.21
javaVersion = "17"

# Kotlin & Coroutines
kotlin = "2.2.0"

Check warning

Code scanning / Android Lint

Newer Library Versions Available Warning

A newer version of org.jetbrains.kotlin.android than 2.2.0 is available: 2.3.0
kotlinxDatetime = "0.7.1"
kotlinxCoroutinesTest = "1.10.2"
robolectric = "4.16"
hilt = "2.57.2"

Check warning

Code scanning / Android Lint

Newer Library Versions Available Warning

A newer version of com.google.dagger.hilt.android than 2.57.2 is available: 2.59
kotlinxDatetime = "0.7.1"
kotlinxCoroutinesTest = "1.10.2"
robolectric = "4.16"
hilt = "2.57.2"

Check warning

Code scanning / Android Lint

Newer Library Versions Available Warning

A newer version of com.google.dagger:hilt-android than 2.57.2 is available: 2.59
kotlinxDatetime = "0.7.1"
kotlinxCoroutinesTest = "1.10.2"
robolectric = "4.16"
hilt = "2.57.2"

Check warning

Code scanning / Android Lint

Newer Library Versions Available Warning

A newer version of com.google.dagger:hilt-android-compiler than 2.57.2 is available: 2.59
@kikoso
Copy link
Collaborator

kikoso commented Jan 26, 2026

@dkhawk , this looks good. Let's wait until the other libraries are published, update them here and merge this PR.

@dkhawk dkhawk force-pushed the fix/update-to-maps-20.0.0 branch from 023d41a to 9752d55 Compare January 27, 2026 23:18
@snippet-bot
Copy link

snippet-bot bot commented Jan 27, 2026

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@dkhawk dkhawk changed the title fix!: upgrade to Maps SDK v20 and resolve build issues chore: verify build health and remove rx samples Jan 27, 2026
- Upgrade Google Maps SDK to v20.0.0 (BREAKING CHANGE: requires new renderer).
- Fix WearOS build by replacing deprecated kotlinOptions with jvmToolchain.
- Resolve WearOS dependency conflicts by using Kotlin BOM.
- Migrate WearOS dependencies and SDK versions to Version Catalog.
- Refactor Version Catalog: extract versions and organize groups.
- Fix FireMarkers sample: correct Google Services plugin application logic.
- FireMarkers: Add explicit error handling for 'Permission Denied'.

BREAKING CHANGE: This release upgrades the Maps SDK to v20.0.0, which may require code changes for the new renderer and other API adjustments.
- Create scripts/verify_all.sh for local verification
- Update CI to run tests and lint
- Remove deprecated snippets/app-rx module
- Fix FireMarkers unit tests
- Update README with verification instructions
@dkhawk dkhawk force-pushed the fix/update-to-maps-20.0.0 branch from 9752d55 to 81f2207 Compare January 27, 2026 23:25
@kikoso
Copy link
Collaborator

kikoso commented Jan 28, 2026

@dkhawk , we would need to check where the snippets from the Rx samples are being used, since the tags are being removed.

@dkhawk dkhawk changed the title chore: verify build health and remove rx samples feat!: update to Maps SDK 2.0.0 and remove Rx samples Jan 28, 2026
dependencies {
// [START_EXCLUDE]
implementation("androidx.core:core-ktx:1.15.0")
implementation("org.jetbrains.kotlin:kotlin-stdlib-jdk7:2.0.21")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are keeping this dependencies as numerics, so they can be read from the region tag.

materialIconsExtended = "1.7.8"

# Google Maps & Places
mapsCompose = "7.0.0"

Check warning

Code scanning / Android Lint

Newer Library Versions Available Warning

A newer version of com.google.maps.android:maps-compose than 7.0.0 is available: 8.0.0
# Testing
espresso = "3.7.0"
junit = "4.13.2"
mockito = "6.2.2"

Check warning

Code scanning / Android Lint

Newer Library Versions Available Warning

A newer version of org.mockito.kotlin:mockito-kotlin than 6.2.2 is available: 6.2.3
}
}
plugins {
id("org.gradle.toolchains.foojay-resolver-convention") version "1.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding this on the version catalog?

dependencyResolutionManagement {
repositoriesMode.set(RepositoriesMode.FAIL_ON_PROJECT_REPOS)
repositories {
mavenLocal()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep this line? mavenLocal() it is probably something that should be done intentionally, otherwise the local .m2 repository will end up packed.

@dkhawk
Copy link
Contributor Author

dkhawk commented Jan 28, 2026

All requested changes have been addressed:

  • Documentation: Added detailed [versions] and [libraries] TOML instructions to WearOS/Wearable/build.gradle.kts for junior developers.
  • Automation: Updated scripts/update_docs_versions.py to automatically sync these new documentation comments.
  • CI: Added a step to lint.yml to run scripts/update_docs_versions.py --check to prevent future drift.
  • Fixes: created a verified green build state (Fixed Foojay 400 error, Hilt compatibility, and README typo).

Ready for final review!

@dkhawk
Copy link
Contributor Author

dkhawk commented Jan 28, 2026

Addressed all feedback:

  • Fixed CI toolchain issues (Foojay/JDK 21).
  • Fixed Hilt/Dagger dependency compatibility.
  • Fixed properties file typo (README).
  • Annotated WearOS/Wearable/build.gradle.kts with detailed Version Catalog instructions and explicit versions.
  • Restored snippets/app-rx (excluded from build) to preserve documentation region tags.

@dkhawk dkhawk changed the title feat!: update to Maps SDK 2.0.0 and remove Rx samples feat!: update to Maps SDK 2.0.0 Jan 28, 2026
Copy link
Collaborator

@kikoso kikoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dkhawk dkhawk merged commit 7e0db8c into main Jan 28, 2026
13 checks passed
@dkhawk dkhawk deleted the fix/update-to-maps-20.0.0 branch January 28, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants